Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: remove unused posts.sitePosts from Redux tree #3602

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Feb 26, 2016

This PR removes sitePosts from the posts subtree because it was never used and was composed of derived data. If we need this in the future, we can recreate it as a memoized selector: see #3522

Testing

  • No changes to ui, since this was never in use.
  • Build passes

cc @aduth @rralian

@gwwar gwwar added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Feb 26, 2016
@gwwar gwwar self-assigned this Feb 26, 2016
@aduth
Copy link
Contributor

aduth commented Feb 26, 2016

👍

@aduth aduth added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 26, 2016
gwwar added a commit that referenced this pull request Feb 26, 2016
Framework: remove unused posts.sitePosts from Redux tree
@gwwar gwwar merged commit 23ffef8 into master Feb 26, 2016
@gwwar gwwar deleted the update/remove-posts-site-posts branch February 26, 2016 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants