Framework: Fix logged-out /design render with persistence enabled #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `persist-redux` flag is on, redux state bootstrapped from the server (on the logged-out /design route) is passed through the DESERIALIZE actions. This change preserves the state passed through those actions for `section` and `hasSidebar`, which are the two fields needed for the client render of logged-out /design.
seear
added
[Feature Group] Appearance & Themes
seear
added
the
[Status] Needs Review
| @@ -79,7 +79,7 @@ export function hasSidebar( state = true, action ) { | |||
| case SERIALIZE: | |||
| return true; | |||
| case DESERIALIZE: | |||
| return true; | |||
| return state; | |||
There was a problem hiding this comment.
Don't forget to update the related tests :)
|
👍 feel free to merge after you update tests in |
And update tests for these fields.
seear
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
@gwwar: thanks for review :) |
seear
added a commit
that referenced
this pull request
Feb 9, 2016
Framework: Fix logged-out /design render with persistence enabled
| const state = section( 'hello', { | ||
| type: SERIALIZE | ||
| } ); | ||
|
|
||
| expect( state ).to.eql( false ); | ||
| expect( state ).to.eql( 'hello' ); |
There was a problem hiding this comment.
:) Might make more sense to change this to a boolean.
There was a problem hiding this comment.
Might make more sense to change this to a boolean.
section can be a string ('design', 'reader' etc) or false, so I think the string is ok, or am I missing something?
There was a problem hiding this comment.
Oh, I forgot we mixed types here! :) This is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
To Test
persist-reduxtotrueinconfig/development.jsonWhen the
persist-reduxflag is enabled, redux state bootstrapped from the server (on the logged-out /design route) is passed through theDESERIALIZEactions. This change preserves the state passed through those actions forsectionandhasSidebar, which are the two fields needed for the client render of logged-out /design./cc @gwwar
An alternative to tweaking the
DESERIALIZEactions would be to merge in the bootstrapped state after deserialization. The downside to that approach being that we would not be taking advantage of the immutable conversions.