Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Fix try&customize for themes on AT sites #11621

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Themes: Fix try&customize for themes on AT sites #11621

merged 1 commit into from
Feb 28, 2017

Conversation

seear
Copy link
Contributor

@seear seear commented Feb 27, 2017

Apply install fix from #11608 to try&customize action now that Automated Transfer sites do not need the -wpcom suffix on theme IDs when installing themes.

To Test

  • Check that the Activate and Try&Customize actions work as expected for wpcom themes on both Jetpack and AT sites

@seear
Themes: Fix try&customize for themes on AT sites
3fe0adf 
Apply install fix from #11608 to try&customize action now that
Automated Transfer sites do not need the -wpcom suffix on theme
IDs when installing themes.
@seear seear added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 27, 2017
@seear seear self-assigned this Feb 27, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/theme-try-customize-at-sites

@matticbot matticbot added the [Size] S Small sized issue label Feb 27, 2017
ockham
ockham approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@seear seear merged commit 826f937 into master Feb 28, 2017
@seear seear deleted the fix/theme-try-customize-at-sites branch February 28, 2017 11:03
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 28, 2017
This was referenced Dec 29, 2020
Open
Open
@awaisab172 awaisab172 mentioned this pull request Mar 15, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@mdno mdno mentioned this pull request Nov 5, 2022
Open
@mayuba mayuba mentioned this pull request Nov 5, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Nov 5, 2022
Open
@anarh anarh mentioned this pull request Nov 5, 2022
Open
@apmarshall apmarshall mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@mdno mdno mentioned this pull request Dec 25, 2022
Open
@apmarshall apmarshall mentioned this pull request Dec 25, 2022
Open
@mayuba mayuba mentioned this pull request Dec 26, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Dec 26, 2022
Open
@anarh anarh mentioned this pull request Dec 26, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Jan 9, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Jan 10, 2023
Open
@anarh anarh mentioned this pull request Nov 28, 2023
Open
@mdno mdno mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
@mdno mdno mentioned this pull request May 14, 2024
Open
@anarh anarh mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budzanowski budzanowski budzanowski approved these changes

@ockham ockham ockham approved these changes

Assignees

@seear seear

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seear @matticbot @ockham @budzanowski