Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Settings: Consolidate info link container styles #11609

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Jetpack Settings: Consolidate info link container styles #11609

merged 1 commit into from
Feb 27, 2017

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Feb 27, 2017 •
edited by oskosk
Loading

Part of #9171.

This PR cleans up some CSS that we duplicated in the development process of Jetpack Settings in Calypso. Previously this CSS was necessary to align the info icon to the right:
screen shot 2017-02-27 at 16 39 30

This PR cleans it up by consolidating all these to use the same class, and removes all obsolete duplicate declarations.

To test:

  • Go to /settings/writing/$site and /settings/discussion/$site for a Jetpack site
  • Verify there are no visual changes with the info icon in all any Jetpack module settings cards.
  • Verify there are no remaining duplications of this CSS declaration within any Jetpack Settings cards.

@tyxla tyxla added [Feature] Site Settings All other general site settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Feb 27, 2017
@tyxla tyxla added this to the Jetpack Module Settings in Calypso milestone Feb 27, 2017
@tyxla tyxla self-assigned this Feb 27, 2017
@matticbot matticbot added the [Size] M Medium sized issue label Feb 27, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/jetpack-settings-info-link-container-styles

@tyxla tyxla changed the title Site Settings: Consolidate info link container styles Jetpack Settings: Consolidate info link container styles Feb 27, 2017
@oskosk
Copy link
Contributor

oskosk commented Feb 27, 2017

Oh yeah, good one!

@oskosk
Copy link
Contributor

oskosk commented Feb 27, 2017

LGTM !

@oskosk oskosk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge labels Feb 27, 2017
@oskosk
Copy link
Contributor

oskosk commented Feb 27, 2017 •
edited
Loading

THIS LGTM. But looks like the publishing tools card and the subscriptions card could use the changes introduced here too.

Ignore and merge

@tyxla tyxla merged commit 300b5ae into master Feb 27, 2017
@tyxla tyxla deleted the update/jetpack-settings-info-link-container-styles branch February 27, 2017 15:12
This was referenced Dec 29, 2020
Open
Open
@awaisab172 awaisab172 mentioned this pull request Mar 15, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@mdno mdno mentioned this pull request Nov 5, 2022
Open
@mayuba mayuba mentioned this pull request Nov 5, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Nov 5, 2022
Open
@anarh anarh mentioned this pull request Nov 5, 2022
Open
@apmarshall apmarshall mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@mdno mdno mentioned this pull request Dec 25, 2022
Open
@apmarshall apmarshall mentioned this pull request Dec 25, 2022
Open
@mayuba mayuba mentioned this pull request Dec 26, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Dec 26, 2022
Open
@anarh anarh mentioned this pull request Dec 26, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Jan 9, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Jan 10, 2023
Open
@anarh anarh mentioned this pull request Nov 28, 2023
Open
@mdno mdno mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
@mdno mdno mentioned this pull request May 14, 2024
Open
@anarh anarh mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

@ryelle ryelle Awaiting requested review from ryelle

@johnHackworth johnHackworth Awaiting requested review from johnHackworth

@roccotripaldi roccotripaldi Awaiting requested review from roccotripaldi

Assignees

@tyxla tyxla

Labels
[Feature] Site Settings All other general site settings. [Size] M Medium sized issue [Type] Janitorial
Projects
None yet
Milestone
Jetpack Settings v1
Development

Successfully merging this pull request may close these issues.
3 participants
@tyxla @matticbot @oskosk