Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Chart: use local dates #100538

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Line Chart: use local dates #100538

merged 3 commits into from
Feb 27, 2025

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Feb 27, 2025

Related to #100451 (review)

Proposed Changes

  • Fix the issue when ticks and points on line don't match

Why are these changes being made?

  • Bug fix

Testing Instructions

  • Please ignore the fact that my paid sub is higher than total subs
Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 27, 2025
@kangzj kangzj requested review from annacmc and a team February 27, 2025 01:44
@kangzj kangzj self-assigned this Feb 27, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 27, 2025
@kangzj kangzj marked this pull request as ready for review February 27, 2025 01:46
@matticbot
Copy link
Contributor

matticbot commented Feb 27, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/local-date-parsing on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 27, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +144 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~80 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-store-app-store-stats-listview                 +142 B  (+0.1%)      +67 B  (+0.2%)
async-load-store-app-store-stats                          +142 B  (+0.1%)      +67 B  (+0.1%)
async-load-calypso-my-sites-stats-pages-subscribers        +31 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@kangzj kangzj merged commit 2657caa into trunk Feb 27, 2025
11 of 13 checks passed
@kangzj kangzj deleted the fix/local-date-parsing branch February 27, 2025 02:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants