Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Update email verification notification on subscription manager #100530

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mehmoodak
Copy link
Member

Related to https://github.com/Automattic/loop/issues/475

Proposed Changes

Like #100439 update following email verification notifcations on subscriptions manager.

  • Subscriptions Manager > More Menu > Import OPML.
  • Subscriptions Manager > Write on Search > Click on Subscribe button
Screenshot 2025-02-25 at 4 47 45 PM

Why are these changes being made?

  • Provides consistency with same feature found on /discover/add-new.
  • The updated notification provides more context by linking the user to /me/account, which has more information on how to verify your email.

Testing Instructions

  • Checkout PR. Create an unverified account or changed this line to
export const isCurrentUserEmailVerified = () => false;
  • Go to reader/subscriptions. Click on More Menu. Click on "Import OPML" and verify the message.
  • Go to reader/subscriptions. Write anything on search. Click on "Subscribe" and verify the message.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Feb 26, 2025
@mehmoodak mehmoodak requested a review from a team as a code owner February 26, 2025 23:32
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 26, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~98 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
reader                                -382 B  (-0.0%)      -98 B  (-0.0%)
write-flow                            -252 B  (-0.0%)      -22 B  (-0.0%)
plugins                               -252 B  (-0.0%)      -22 B  (-0.0%)
jetpack-cloud-plugin-management       -252 B  (-0.0%)      -22 B  (-0.0%)
home                                  -252 B  (-0.0%)      -22 B  (-0.0%)
build-flow                            -252 B  (-0.0%)      -22 B  (-0.0%)
a8c-for-agencies-plugins              -252 B  (-0.0%)      -22 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~46 bytes removed 📉 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                  -316 B  (-0.0%)      -46 B  (-0.0%)
async-load-calypso-components-web-preview-component       -252 B  (-0.1%)      -22 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug loop-475/update-email-verification-messaging-on-subscriptions-manager on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants