-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Focused Launchpad for all onboarding users #100526
base: trunk
Are you sure you want to change the base?
Enable Focused Launchpad for all onboarding users #100526
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
} as SiteDetails; | ||
|
||
expect( await shouldShowLaunchpadFirst( site ) ).toBe( false ); | ||
} ); | ||
} ); | ||
|
||
describe( 'useShouldShowLaunchpadFirst', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel bad removing a good part of this test @p-jackson. Such a good work!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, using A/B testing to help us make decisions definitely doesn't come for free! Kinda frustrating spending the time to handle all the cases just to have it all removed for some reason 🤖🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I also don't think these test cases took me too long, I think it's just copy pasting the same test cases from above, but then converted to work as a hook)
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~527 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulopmt1 Works well! I also removed some tests that were failing but no longer applies since we are always showing focused launchpad and it does not depends on experiment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discovered some problem, haven't gotten to the bottom of it yet.
I have here an unlaunched site with a write
intent. When I'm in the cumulative group (which even though the experiment is disabled, there are still users in the cumulative group) then the launchpad works as expected.
But when I'm in the control
group, the design task is going to the wrong place. To the stepper version of the design updater. I'm pretty sure this is behaving like the full screen launchpad 🤔 And then if I click the back button I'm really messed up.
Follow-up of: #99914
Related to: #99879
Proposed Changes
treatment_cumulative
group. Now we're releasing it to all onboarding users.Why are these changes being made?
This is primarily a cosmetic change, and we decided to have it available to all onboarding users.
Slack thread: p1740604199288619-slack-C057AH42XQD
Testing Instructions
Remove any cache you may have, or use an incognito tab
Go to /setup/onboarding
Finish the onboarding, and you should see the Focused Launchpad:

When navigating back and forth on the /home page, you should keep seeing it until you either dismiss or launch your site.
Make sure flows like /start/personal/ still use the old launchpad:
Note: Asked here to see if we should enable it to all flows: p1740608836896969/1740604199.288619-slack-C057AH42XQD
Pre-merge Checklist