Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Focused Launchpad for all onboarding users #100526

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Feb 26, 2025

Follow-up of: #99914
Related to: #99879

Proposed Changes

  • We ended the experiment and Focused Launchpad was tied to treatment_cumulative group. Now we're releasing it to all onboarding users.

Why are these changes being made?

This is primarily a cosmetic change, and we decided to have it available to all onboarding users.
Slack thread: p1740604199288619-slack-C057AH42XQD

Testing Instructions

  • Remove any cache you may have, or use an incognito tab

  • Go to /setup/onboarding

  • Finish the onboarding, and you should see the Focused Launchpad:
    Screenshot 2025-02-26 at 19 03 16

  • When navigating back and forth on the /home page, you should keep seeing it until you either dismiss or launch your site.

  • Make sure flows like /start/personal/ still use the old launchpad:

Note: Asked here to see if we should enable it to all flows: p1740608836896969/1740604199.288619-slack-C057AH42XQD

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/release-focused-launchpad-to-onboarding-users on your sandbox.

} as SiteDetails;

expect( await shouldShowLaunchpadFirst( site ) ).toBe( false );
} );
} );

describe( 'useShouldShowLaunchpadFirst', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel bad removing a good part of this test @p-jackson. Such a good work!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, using A/B testing to help us make decisions definitely doesn't come for free! Kinda frustrating spending the time to handle all the cases just to have it all removed for some reason 🤖🤓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I also don't think these test cases took me too long, I think it's just copy pasting the same test cases from above, but then converted to work as a hook)

@paulopmt1 paulopmt1 requested a review from a team February 26, 2025 22:22
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2025
@paulopmt1 paulopmt1 changed the title Enable Focused Launchpad to all onboarding users Enable Focused Launchpad for all onboarding users Feb 26, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~527 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
write-flow       -548 B  (-0.0%)     -256 B  (-0.1%)
build-flow       -548 B  (-0.0%)     -256 B  (-0.1%)
home             -535 B  (-0.0%)     -271 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulopmt1 Works well! I also removed some tests that were failing but no longer applies since we are always showing focused launchpad and it does not depends on experiment

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered some problem, haven't gotten to the bottom of it yet.

I have here an unlaunched site with a write intent. When I'm in the cumulative group (which even though the experiment is disabled, there are still users in the cumulative group) then the launchpad works as expected.
But when I'm in the control group, the design task is going to the wrong place. To the stepper version of the design updater. I'm pretty sure this is behaving like the full screen launchpad 🤔 And then if I click the back button I'm really messed up.

CleanShot.2025-02-27.at.16.31.49.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants