Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: use different Y scales for paid & total lines #100525

Merged
merged 13 commits into from
Feb 27, 2025

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Feb 26, 2025

Related to #

Proposed Changes

  • Use different scale when total and paid are too far away

Why are these changes being made?

  • Visual improvement for chart

Testing Instructions

  • Replace function transformLineChartData in client/my-sites/stats/stats-subscribers-chart-section/index.tsx with the following
const transformLineChartData = (
	data: SubscribersData[],
	hasAddedPaidSubscriptionProduct: boolean
): ChartDataPoint[][] => {
	const subscribersData: ChartDataPoint[] = [];
	const paidSubscribersData: ChartDataPoint[] = [];
	data?.map( ( point ) => {
		const dateObj = new Date( point.period );
		if ( isNaN( dateObj.getTime() ) ) {
			return null;
		}

		subscribersData.push( {
			date: dateObj,
			value: point.subscribers * Math.random() * 100_000,
		} );

		// if ( hasAddedPaidSubscriptionProduct ) {
			paidSubscribersData.push( {
				date: dateObj,
				value: point.subscribers * Math.random() * 100,
			} );
		// }
	} );
	return [ subscribersData, paidSubscribersData ];
};
  • Open http://calypso.localhost:3000/stats/subscribers/day/xx.au.ngrok.io?flags=stats/chart-library
  • Ensure you can see the trend for both paid and total subscribers
  • Change 100_000 and 100 to some other numbers
  • Ensure the chart still looks reasonable

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 26, 2025
@kangzj kangzj requested a review from annacmc February 26, 2025 22:05
@kangzj kangzj self-assigned this Feb 26, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 26, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~82 bytes added 📈 [gzipped])

name                                                     parsed_size           gzip_size
async-load-calypso-my-sites-stats-components-line-chart       +222 B  (+0.1%)      +82 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/use-log-y-scale-for-paid-total-lines on your sandbox.

@kangzj kangzj requested a review from a team February 27, 2025 01:00
@kangzj kangzj marked this pull request as ready for review February 27, 2025 01:00
@kangzj kangzj changed the title Stats: use log y scale for paid total lines Stats: use different Y scales for paid & total lines Feb 27, 2025
@kangzj kangzj merged commit 6f8cd18 into trunk Feb 27, 2025
16 checks passed
@kangzj kangzj deleted the fix/use-log-y-scale-for-paid-total-lines branch February 27, 2025 02:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants