Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show the updated free site modal copy #100524

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

p-jackson
Copy link
Member

Related to #

Proposed Changes

Removes the treatment_cumulative guard from the updated copy
Removes the hasEnTranslation checks because the mag16 translations are complete https://translate.wordpress.com/deliverables/overview/17228935

Why are these changes being made?

The treatment_cumulative cohort is being tidied up.
p1740604655941889-slack-C057AH42XQD

While working on this tidy up I realise it only impacts a few users: users who signed up a few days ago (while the experiment was still running) and were assigned to the treatment_frozen cohort. They'll now see the new copy if they happen to go through onboarding again.

Still worth a tidy up so we can get rid of this flag from the code though.

Testing Instructions

Since the experiment has wrapped up, you'll need to assign your test user to a cohort manually: 22180-explat-experiment. Unless you have existing test users.

  • Go to /setup/onboarding - with a goals-first variant - and choose Big Sky
  • Go to plans page and click on start with a free plan
  • Check the modal's copy to ensure they're good and compatible with the previous translation while we wait for the new one to come.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson p-jackson requested a review from a team February 26, 2025 21:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2025
@p-jackson p-jackson self-assigned this Feb 26, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~18 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
entry-main       -180 B  (-0.0%)      -18 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~5882 bytes removed 📉 [gzipped])

name                        parsed_size           gzip_size
plugins                        -14086 B  (-0.4%)    -5590 B  (-0.6%)
plans                          -14073 B  (-1.0%)    -5588 B  (-1.3%)
jetpack-app                    -14073 B  (-2.9%)    -5572 B  (-3.6%)
update-design-flow              -1825 B  (-0.1%)     -393 B  (-0.1%)
async-step-unified-plans        -1825 B  (-0.2%)     -393 B  (-0.2%)
signup                           -440 B  (-0.1%)       -5 B  (-0.0%)
async-step-unified-domains       -440 B  (-0.0%)       -7 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~5759 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected     -14073 B  (-3.0%)    -5598 B  (-3.7%)
async-load-signup-steps-plans                       -14073 B  (-3.0%)    -5606 B  (-3.8%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/free-site-modal-copy-no-experiment on your sandbox.

@vykes-mac vykes-mac force-pushed the update/free-site-modal-copy-no-experiment branch from 178bcc4 to 7a866d2 Compare February 27, 2025 00:13
@vykes-mac
Copy link
Contributor

@p-jackson I accidentally push a change to this branch that shouldn't be 😅

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks correct. Even though I didn't see business plan on the modal.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants