-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always show the updated free site modal copy #100524
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~18 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~5882 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~5759 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
178bcc4
to
7a866d2
Compare
@p-jackson I accidentally push a change to this branch that shouldn't be 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #
Proposed Changes
Removes the
treatment_cumulative
guard from the updated copyRemoves the
hasEnTranslation
checks because the mag16 translations are complete https://translate.wordpress.com/deliverables/overview/17228935Why are these changes being made?
The
treatment_cumulative
cohort is being tidied up.p1740604655941889-slack-C057AH42XQD
While working on this tidy up I realise it only impacts a few users: users who signed up a few days ago (while the experiment was still running) and were assigned to the
treatment_frozen
cohort. They'll now see the new copy if they happen to go through onboarding again.Still worth a tidy up so we can get rid of this flag from the code though.
Testing Instructions
Since the experiment has wrapped up, you'll need to assign your test user to a cohort manually: 22180-explat-experiment. Unless you have existing test users.
start with a free plan
Pre-merge Checklist