Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy for Bi Sky design selection + free plan modal to get translation package in time #99124

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add copy for Bi Sky design selection + free plan modal to get translation package in time #99124

wants to merge 2 commits into from
+24 −0

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Jan 30, 2025 •
edited
Loading

Related to #99120

Proposed Changes

  • We're anticipating strings translation. Adding [Status] String Freeze is enough to get the translation process started.
  • Add new modal strings

Image

Image

Testing Instructions

  • Make sure we have all the strings we need

@paulopmt1 paulopmt1 requested a review from a team as a code owner January 30, 2025 18:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@paulopmt1 paulopmt1 self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131549
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131549&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131549&env=a8c-for-agencies

@paulopmt1 paulopmt1 added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging DO NOT MERGE and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 30, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@paulopmt1 paulopmt1 linked an issue Jan 30, 2025 that may be closed by this pull request
Task: Anticipate translation of new Big Sky modal copy #99120
Open
2 tasks
@paulopmt1 paulopmt1 removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 30, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1897 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper            +101877 B  (+7.5%)   +35326 B  (+9.3%)
entry-subscriptions        +1284 B  (+0.1%)      +24 B  (+0.0%)
entry-login                 +974 B  (+0.0%)     -473 B  (-0.1%)
entry-domains-landing       +925 B  (+0.1%)     +601 B  (+0.3%)
entry-main                  +916 B  (+0.0%)     -182 B  (-0.0%)
entry-browsehappy           +873 B  (+0.4%)     +579 B  (+0.9%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~39031 bytes removed 📉 [gzipped])

name                                parsed_size            gzip_size
link-in-bio-tld-flow                  -123949 B   (-5.4%)   -35097 B   (-5.2%)
update-design-flow                    -123913 B   (-7.8%)   -35267 B   (-7.6%)
copy-site-flow                        -113180 B  (-10.5%)   -34737 B  (-10.6%)
stepper-user-step                     -112848 B  (-43.6%)   -35846 B  (-43.4%)
entrepreneur-flow                     -112848 B  (-55.8%)   -35848 B  (-54.5%)
domain-user-transfer-flow             -112848 B  (-29.8%)   -35860 B  (-38.6%)
transferring-hosted-site-flow         -112760 B  (-42.4%)   -35843 B  (-41.1%)
plugin-bundle-flow                    -112684 B  (-22.0%)   -35104 B  (-22.0%)
newsletter-post-setup-flow            -112665 B  (-41.1%)   -35507 B  (-39.0%)
link-in-bio-post-setup-flow           -112665 B  (-41.1%)   -35507 B  (-39.0%)
write-flow                            -112660 B   (-9.3%)   -35365 B   (-9.6%)
build-flow                            -112660 B   (-9.3%)   -35374 B   (-9.6%)
import-hosted-site-flow               -112540 B   (-8.9%)   -35794 B   (-9.5%)
signup                                 -11196 B   (-3.8%)     -137 B   (-0.2%)
start-writing-flow                      -1761 B   (-6.3%)       -1 B   (-0.0%)
design-first-flow                       -1653 B   (-5.8%)       +2 B   (+0.0%)
newsletter-flow                         -1376 B   (-6.1%)      +25 B   (+0.5%)
hundred-year-plan                       -1230 B   (-0.6%)      -10 B   (-0.0%)
new-hosted-site-flow                     -672 B   (-0.4%)      -21 B   (-0.0%)
new-hosted-site-flow-user-included       -651 B   (-0.4%)      -30 B   (-0.1%)
onboarding-flow                          -645 B   (-0.3%)      +53 B   (+0.1%)
hundred-year-domain-transfer             -624 B   (-9.4%)      -33 B   (-1.8%)
google-transfer                          -624 B  (-11.1%)      -36 B   (-2.3%)
domain-transfer                          -624 B  (-11.6%)      -40 B   (-2.6%)
account                                  +583 B   (+0.1%)       +0 B
connect-domain                           -573 B   (-0.3%)      -35 B   (-0.1%)
tailored-ecommerce-flow                  -558 B   (-8.4%)      -37 B   (-1.6%)
reblogging-flow                          -510 B   (-6.8%)      +11 B   (+0.5%)
posts                                    -309 B   (-0.0%)       -6 B   (-0.0%)
home                                     -301 B   (-0.0%)    -1020 B   (-0.2%)
notification-settings                    +272 B   (+0.0%)     +409 B   (+0.2%)
a8c-for-agencies-sites                   +272 B   (+0.0%)    -1487 B   (-0.2%)
privacy                                  +247 B   (+0.0%)     +251 B   (+0.2%)
developer                                +247 B   (+0.0%)     +215 B   (+0.1%)
site-setup-wg                            +245 B   (+0.1%)      +36 B   (+0.0%)
site-setup-flow                          +245 B   (+0.1%)      +36 B   (+0.0%)
help                                     +233 B   (+0.0%)     -178 B   (-0.1%)
hundred-year-domain                      -222 B   (-0.1%)      -10 B   (-0.0%)
site-blocks                              +220 B   (+0.0%)     -235 B   (-0.1%)
a8c-for-agencies-migrations              +196 B   (+0.0%)    +1302 B   (+0.5%)
a8c-for-agencies-purchases               +128 B   (+0.0%)     +525 B   (+0.2%)
devdocs                                  -108 B   (-0.1%)      -53 B   (-0.1%)
me                                       +104 B   (+0.0%)     -251 B   (-0.2%)
theme                                    +103 B   (+0.0%)      +16 B   (+0.0%)
readymade-template-flow                  +103 B   (+0.1%)      +11 B   (+0.0%)
jetpack-cloud-partner-portal             -103 B   (-0.0%)      -32 B   (-0.0%)
jetpack-cloud-manage-pricing             -103 B   (-0.0%)      -34 B   (-0.0%)
import                                   +103 B   (+0.0%)      +23 B   (+0.0%)
assembler-first-flow                     +103 B   (+0.1%)      +11 B   (+0.0%)
themes                                   -102 B   (-0.0%)      -30 B   (-0.0%)
staging-site                             -102 B   (-0.0%)      -20 B   (-0.0%)
site-tools                               -102 B   (-0.0%)      -20 B   (-0.0%)
site-settings                            -102 B   (-0.0%)      -18 B   (-0.0%)
site-marketing                           -102 B   (-0.0%)      -17 B   (-0.0%)
settings-security                        -102 B   (-0.0%)      -18 B   (-0.0%)
settings-podcast                         -102 B   (-0.0%)      -18 B   (-0.0%)
settings-performance                     -102 B   (-0.0%)      -20 B   (-0.0%)
settings                                 -102 B   (-0.0%)      -18 B   (-0.0%)
posts-custom                             -102 B   (-0.0%)     -104 B   (-0.0%)
marketing                                -102 B   (-0.0%)      -17 B   (-0.0%)
hosting                                  -102 B   (-0.0%)      -20 B   (-0.0%)
earn                                     -102 B   (-0.0%)      -19 B   (-0.0%)
domains                                  -102 B   (-0.0%)      -19 B   (-0.0%)
activity                                 -102 B   (-0.0%)      -19 B   (-0.0%)
security                                 +100 B   (+0.0%)     -494 B   (-0.2%)
a8c-for-agencies-marketplace              +93 B   (+0.0%)    +1406 B   (+0.5%)
people                                    +77 B   (+0.0%)     +227 B   (+0.1%)
a8c-for-agencies-client                   +64 B   (+0.0%)     +245 B   (+0.1%)
site-purchases                            -26 B   (-0.0%)      +38 B   (+0.0%)
purchases                                 -26 B   (-0.0%)      +19 B   (+0.0%)
account-close                             +24 B   (+0.0%)     -416 B   (-0.2%)
media                                     -13 B   (-0.0%)      -17 B   (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~43210 bytes removed 📉 [gzipped])

name                                                                              parsed_size            gzip_size
async-load-calypso-my-sites-checkout-modal                                          -113232 B   (-6.9%)   -35480 B   (-7.5%)
async-load-automattic-help-center-stepper                                           -112858 B  (-11.5%)   -35458 B  (-12.2%)
async-load-signup-steps-page-picker                                                  -20392 B   (-4.8%)    -6392 B   (-4.8%)
async-load-signup-steps-new-or-existing-site                                         -20354 B  (-26.2%)    -6343 B  (-25.1%)
async-load-signup-steps-domains                                                      -20352 B   (-3.1%)    -6126 B   (-3.1%)
async-load-signup-steps-woocommerce-install                                          -20341 B  (-92.0%)    -6335 B  (-89.1%)
async-load-signup-steps-website-content                                              -20341 B   (-9.7%)    -6324 B   (-9.2%)
async-load-signup-steps-user                                                         -20341 B   (-8.4%)    -6335 B   (-8.5%)
async-load-signup-steps-store-features                                               -20341 B  (-26.4%)    -6335 B  (-25.9%)
async-load-signup-steps-starting-point                                               -20341 B  (-30.0%)    -6335 B  (-29.2%)
async-load-signup-steps-site-picker                                                  -20341 B   (-8.1%)    -6326 B   (-7.9%)
async-load-signup-steps-site-or-domain                                               -20341 B  (-28.5%)    -6327 B  (-28.0%)
async-load-signup-steps-p2-site                                                      -20341 B  (-23.8%)    -6335 B  (-23.8%)
async-load-signup-steps-p2-join-workspace                                            -20341 B  (-31.6%)    -6335 B  (-30.1%)
async-load-signup-steps-p2-details                                                   -20341 B  (-35.1%)    -6335 B  (-32.9%)
async-load-signup-steps-p2-confirm-email                                             -20341 B  (-35.1%)    -6335 B  (-33.1%)
async-load-signup-steps-p2-complete-profile                                          -20341 B  (-12.7%)    -6335 B  (-12.3%)
async-load-signup-steps-intent                                                       -20341 B  (-28.7%)    -6335 B  (-27.9%)
async-load-signup-steps-difm-site-picker                                             -20341 B   (-8.1%)    -6326 B   (-7.9%)
async-load-calypso-signup-step-wrapper                                               -20341 B  (-57.8%)    -6335 B  (-56.1%)
async-load-calypso-blocks-jitm-templates-modal                                       -20341 B  (-43.6%)    -6335 B  (-41.4%)
async-load-automattic-onboarding-src-step-container                                  -20341 B  (-71.7%)    -6335 B  (-68.1%)
async-load-signup-steps-design-picker                                                -20316 B  (-22.5%)    -6306 B  (-21.4%)
async-load-signup-steps-woocommerce-install-transfer                                 -20238 B  (-31.0%)    -6305 B  (-29.7%)
async-load-signup-steps-woocommerce-install-step-store-address                       -20238 B  (-19.8%)    -6305 B  (-18.7%)
async-load-signup-steps-woocommerce-install-step-business-info                       -20238 B  (-16.2%)    -6306 B  (-15.4%)
async-load-signup-steps-woocommerce-install-confirm                                  -20238 B  (-23.0%)    -6304 B  (-22.3%)
async-load-signup-steps-theme-selection                                              -20238 B   (-6.1%)    -6300 B   (-6.1%)
async-load-signup-steps-test-step                                                    -20238 B  (-38.5%)    -6300 B  (-36.6%)
async-load-signup-steps-social-profiles                                              -20238 B  (-34.4%)    -6301 B  (-33.0%)
async-load-signup-steps-site                                                         -20238 B  (-26.6%)    -6299 B  (-26.2%)
async-load-signup-steps-rewind-were-backing                                          -20238 B  (-37.4%)    -6298 B  (-35.5%)
async-load-signup-steps-rewind-form-creds                                            -20238 B  (-19.8%)    -6299 B  (-19.5%)
async-load-signup-steps-initial-intent                                               -20238 B  (-18.4%)    -6309 B  (-17.4%)
async-load-signup-steps-hosting-decider                                              -20238 B  (-36.6%)    -6304 B  (-34.2%)
async-load-signup-steps-emails                                                       -20238 B  (-21.6%)    -6302 B  (-21.0%)
async-load-signup-steps-creds-permission                                             -20238 B  (-23.7%)    -6300 B  (-23.0%)
async-load-signup-steps-creds-confirm                                                -20238 B  (-24.2%)    -6300 B  (-23.5%)
async-load-signup-steps-courses                                                      -20238 B  (-16.3%)    -6301 B  (-15.7%)
async-load-signup-steps-clone-start                                                  -20238 B  (-34.2%)    -6298 B  (-32.5%)
async-load-signup-steps-clone-ready                                                  -20238 B  (-23.7%)    -6299 B  (-23.8%)
async-load-signup-steps-clone-point                                                  -20238 B   (-7.2%)    -6301 B   (-8.0%)
async-load-signup-steps-clone-destination                                            -20238 B  (-31.5%)    -6299 B  (-30.8%)
async-load-signup-steps-clone-credentials                                            -20238 B  (-19.3%)    -6299 B  (-19.2%)
async-load-signup-steps-clone-cloning                                                -20238 B  (-34.4%)    -6303 B  (-32.9%)
async-load-signup-steps-site-options                                                 -20135 B  (-27.3%)    -6271 B  (-26.8%)
async-load-design-blocks                                                               -427 B   (-0.0%)     -595 B   (-0.1%)
async-load-signup-steps-plans-theme-preselected                                        -156 B   (-0.0%)      -27 B   (-0.0%)
async-load-signup-steps-plans                                                          -156 B   (-0.0%)      -27 B   (-0.0%)
async-load-design-playground                                                           +103 B   (+0.0%)      -24 B   (-0.0%)
async-load-design                                                                      +103 B   (+0.0%)      -24 B   (-0.0%)
async-load-automattic-search                                                           -103 B   (-0.3%)      -40 B   (-0.3%)
async-load-calypso-reader-sidebar                                                      -102 B   (-0.1%)      -19 B   (-0.1%)
async-load-calypso-my-sites-current-site-notice                                        -102 B   (-0.2%)      -17 B   (-0.1%)
async-load-calypso-components-web-preview-component                                    -102 B   (-0.0%)       +0 B
async-load-calypso-blocks-jitm-templates-sidebar-banner                                -102 B   (-0.2%)      -17 B   (-0.1%)
async-load-calypso-blocks-jitm-templates-notice                                        -102 B   (-0.2%)      -18 B   (-0.1%)
async-load-calypso-blocks-jitm-templates-default                                       -102 B   (-0.2%)      -19 B   (-0.1%)
async-load-calypso-blocks-jitm                                                          -78 B   (-0.1%)      -10 B   (-0.0%)
async-load-purchase-modal-wrapper                                                       -51 B   (-0.0%)      -67 B   (-0.1%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -51 B   (-0.0%)      -67 B   (-0.1%)
async-load-calypso-post-editor-media-modal                                              -13 B   (-0.0%)      -18 B   (-0.0%)
async-load-calypso-post-editor-editor-media-modal                                       -13 B   (-0.0%)      -18 B   (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 30, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/copy-for-big-sky-selection-design-and-free-plan-modal on your sandbox.

@a8ci18n
Copy link

a8ci18n commented Jan 30, 2025 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17219960

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulopmt1 paulopmt1

Labels
DO NOT MERGE [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Anticipate translation of new Big Sky modal copy
3 participants
@paulopmt1 @matticbot @a8ci18n