Staging sites: Update error notice message when Studio import is in progress

[ivan-ottinger]

Resolves https://github.com/Automattic/dotcom-forge/issues/10008.

Proposed Changes

• update error notice message when Studio import is in progress

Note

I originally aimed to adjust the error logic on a deeper level (as can be seen in #98156), but then decided to adjust the error message only.

The changes proposed in this PR are much simpler and solve the issue without touching the error logic.

Why are these changes being made?

• https://github.com/Automattic/dotcom-forge/issues/10008.

Testing Instructions

1. Create an Atomic site and ensure it also has a staging site attached (http://calypso.localhost:3000/staging-site/{site-slug}).
2. Open the Studio app and connect the Atomic site to one of your local sites.
3. Initiate the Push operation to your staging site and wait until the Applying changes... status message displays above the progress bar.
4. Head over to the http://calypso.localhost:3000/staging-site/{site-slug} settings page and try to initiate the sync from production to the staging site.
5. The process should fail with the new error message - as can be seen in the screenshot above.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129743

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129743&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129743&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~40 bytes added 📈 [gzipped])

name          parsed_size           gzip_size
staging-site        -50 B  (-0.0%)      +17 B  (+0.0%)
site-tools          -50 B  (-0.0%)      +23 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/staging-sync-error-message-on-studio-push-in-progress on your sandbox.

[wojtekn]

Looks good. Agreed on the proposed cleanup, though.

[ivan-ottinger]

Thank you for your review and feedback, @nightnei and @wojtekn. I have cleaned up the types in 3cb58a5.

[nightnei]

LGTM
Thanks for cleaning it up 👍

[nightnei]

@ivan-ottinger Only one thing - I did everything according to testing instruction and I got another error, is it ok?

[ivan-ottinger]

@ivan-ottinger Only one thing - I did everything according to testing instruction and I got another error, is it ok?

Thank you for testing this again, @nightnei.

Looks like some other error (other than studio_import_in_progress) got triggered there: fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Sfvgr%2Qfgntvat%2Spynff.fvgr%2Qfgntvat%2Qflap%2Qznantre.cuc%3Se%3Qp88s2260%26zb%3Q24002%26sv%3Q806%23782%2Q810-og (e.g. Sync already in progress.).

Are you getting that other error repeatedly when following the testing instructions? 🤔

[ivan-ottinger]

Just noting that I have tested the PR again and it is working as expected. → Will merge and deploy the PR.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17196136

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators.

[emilyaudela]

For translation purposes, would it be possible to do 2 separate strings for each environment?

1. We couldn’t synchronize the staging environment.
2. We couldn’t synchronize the production environment.

In some languages, the variable will change the way "environment" needs to be translated, making it hard for translators to make sure both instances are grammatically correct.

[ivan-ottinger]

Thats is a good point. Thanks for bringing it up, @emilyaudela. I see the issue has been there before and will fix it in a separate PR.

[ivan-ottinger]

Created new task: https://github.com/Automattic/dotcom-forge/issues/10290.

[a8ci18n]

Translation for this Pull Request has now been finished.