Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Allowing "Force Footer to Bottom of Page" #76617

Open
masperber opened this issue May 5, 2023 · 5 comments
Open

Consider Allowing "Force Footer to Bottom of Page" #76617

masperber opened this issue May 5, 2023 · 5 comments
Labels
[Feature] Full Site Editor The site editor. [Pri] Low [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@masperber
Copy link

What

In some cases, a user may choose to create a page with relatively little content that does not fill an entire page. In this case, the user might wish for the footer to appear at the bottom of the screen instead of immediately below the content.

Screenshot 2023-05-04 at 10 50 08 PM

Why

For pages where there is enough content to fill an entire page, the footer will appear at the bottom of the page when the visitor scrolls to the bottom. If the footer appears floating in the middle of a page with not enough content to fill the page, it may cause that page to not appear cohesive with the rest of the site.

How

Add a toggle option to Footer template parts and/or Group Blocks, similar to the toggle that allows Group blocks to be designated as "sticky headers."

@karenroldan
Copy link
Contributor

📌 ACTIONS

  • Replaced issue type with a bug
  • Requested author feedback

📌 Message to Author

  • Can you share the theme used for this? The footer appearing in the middle of the page should not be the intended behavior.

@masperber
Copy link
Author

@karenroldan this can be reproduced with any FSE theme.

@cuemarie
Copy link

I can replicate the footer not sticking to the bottom of a short page in simple and AT sites:

Simple Site, TT2 Theme

Markup on 2023-05-16 at 12:21:17

Atomic Site, Blank Canvas Theme

Markup on 2023-05-16 at 12:24:36

@cuemarie
Copy link

Still working on determining where best to take this next - it feels like it would pertain to FSE work in /gutenberg, so I've asked for some help connecting it to any existing issues, before I report it anew. p1684868062118849-slack-C03EUR81G3V

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Feature] Full Site Editor The site editor. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests and removed [Status] Needs Author Reply [Type] Bug labels May 23, 2023
@cuemarie
Copy link

Ok, my conversation over in p1684868062118849-slack-C03EUR81G3V was helpful! Hat tip to @kathrynwp for their assistance. A couple takeaways:

First, this is working by design; in fact, the same thing happens in Classic Themes as well (Example: Morden):
Markup on 2023-05-23 at 12:07:18

Second, the best /gutenberg issue to follow for this is this one:

📌 ACTIONS

  • Relabeled as a Feature Request again
  • Feature request kept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Pri] Low [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Projects
None yet
Development

No branches or pull requests

3 participants