Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Submenus with background color inherit CSS on pages where list block is present #75908

Closed
syhussaini opened this issue Apr 18, 2023 · 15 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. Navigation [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@syhussaini
Copy link

syhussaini commented Apr 18, 2023

2023-04-18 Update - Findings show that this is not unique to Bitácora, but to any FSE theme where the submenu has a background color. Relevant Gutenberg report: WordPress/gutenberg#49445 -cuemarie

Quick summary

Bitácora Theme shows submenus with additional Padding when the Page has a list of items added using List Block. The submenu appears correctly when the page without a List Block is viewed.

Please see this image for reference:

Steps to reproduce

  1. Activate Bitácora theme.
  2. Now add submenu items in the menu
  3. Add a new page with List Block
  4. Now view the page with the List Block to see the menu appear with additional padding.submenu items

What you expected to happen

The menu should appear the same as it appears when on a page without a List Block.

image

What actually happened

The submenu appears with additional padding.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@syhussaini syhussaini added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Apr 18, 2023
@github-actions github-actions bot added [Platform] Simple [Pri] Low Address when resources are available. labels Apr 18, 2023
@syhussaini
Copy link
Author

user on this ticket 6211163-zen is impacted with this issue.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6211163-zen
  • 6158230-zen
  • 6267568-zen
  • 6279660-zen
  • 6318112-zen
  • 6569091-zen
  • 6773296-zen
  • 7391190-zen

@cuemarie
Copy link

cuemarie commented Apr 18, 2023

Very similar issue reported here on Munchies theme:

I've been having trouble replicating but perhaps between the two I can figure this out :)

@cuemarie
Copy link

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I was able to replicate this on a brand new Free site, created today:
c6K55E.mp4

Looks like it's stemming from this inline CSS:

ol.has-background, ul.has-background {
  padding: 1.25em 2.375em;
}

Which is overriding the default padding setting for the .wp-block-navigation ul:

.wp-block-navigation ul, .wp-block-navigation ul li {
  list-style: none;
  padding: 0;
}

0MZj5V.gif

Same result on AT and Simple, tested with CTGL, Vetro, and

AT Site, Vetro

UIQMLk.gif

Simple Site, CTGL
vk7dPs.gif

**Simple Site, TT3 (Default)
Ry35sZ.png

📌 ACTIONS

@cuemarie cuemarie changed the title Bitácora Theme shows Sub Menus with additional Padding FSE: Submenus with background color inherit CSS on pages where list block is present Apr 19, 2023
@cuemarie cuemarie added [Pri] Normal Schedule for the next available opportuinity. Navigation [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Feature] Full Site Editor The site editor. [Platform] Atomic and removed [Pri] Low Address when resources are available. labels Apr 19, 2023
@cuemarie
Copy link

User report from #75244, who would like to be notified when this is resolved:

  • 6158230-zd-woothemes

@cuemarie
Copy link

cuemarie commented May 4, 2023

Ran into this here: 42217934-hc

Provided the following CSS as a workaround:

/* fix submenu padding bug | xxx-hc [XX] */
.wp-block-navigation ul, .wp-block-navigation ul li {
  list-style: none;
  padding: 0;
}

@cuemarie
Copy link

cuemarie commented May 9, 2023

@cuemarie
Copy link

cuemarie commented May 9, 2023

@ariel-maidana
Copy link

6267568-zd-woothemes
Please notify the user once this issue is fixed.

@ariel-maidana
Copy link

Another case here: 6279660-zd-woothemes
Please let the user know once this issue is fixed.

@sourourn
Copy link

Another case here: 6318112-zd-woothemes
Please let the user know once this issue is fixed.

@jp-imagines
Copy link

Came across another instance in 6569091-zd-woothemes, gave CSS to fix. Follow-up not needed.

@CodeAllNightNDay
Copy link

Encountered the issue here:
6773296-zen

Gave CSS for the workaround.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 5, 2023
@eduardozulian
Copy link
Member

Another report in 7391190-zen, using the Munchies theme. Shared the following CSS as a workaround:

ul.wp-block-navigation-submenu.has-background {
    padding: 0;
}

@annezazu
Copy link

Digging through layers of reports on the Gutenberg GitHub repo and this should have been resolved:

WordPress/gutenberg#50486 (comment)

I am going to close this out but let's please reopen and/or flag for me if folks can still replicate this. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. Navigation [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

8 participants