Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE > Navigation Block: Parent menu items lose typography settings/customization when adding submenus #74016

Closed
Gustavo-Hilario opened this issue Mar 2, 2023 · 4 comments
Labels
[Feature] Full Site Editor The site editor. Navigation [Platform] Atomic [Platform] Simple [Pri] Low [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@Gustavo-Hilario
Copy link

Gustavo-Hilario commented Mar 2, 2023

Quick summary

When you add a menu item you can change the font size and typography, but if you add a submenu to that item, the typography setting is gone, and the changes made before reset to the default of the Navigation block.

Steps to reproduce

  1. Activate an FSE theme.
  2. Open the Site Editor and select the Navigation menu.
  3. Select a Menu item and change the typography setting.
  4. Add a submenu to that Menu item, and the typography goes back to the default value.
  5. Open the settings of the Menu item to change the typography.

What you expected to happen

Font applied to the parent menu item to not change when adding a submenu. Then, to be able to change the font family of the parent menu item when it has a submenu.

What actually happened

The typography setting of the parent menu item is gone when adding a submenu. Also, if you change it before adding the submenu, the typography setting resets to the default values.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

Workaround: Change the font for the Navigation block. That would change fonts for all menu items, though.

How to reproduce the issue:

Screen.Capture.on.2023-03-02.at.15-26-52.mp4
@Gustavo-Hilario Gustavo-Hilario added [Type] Bug User Report This issue was created following a WordPress customer report labels Mar 2, 2023
@Gustavo-Hilario Gustavo-Hilario changed the title FSE: Parent menu items lose typography settings/customization when adding submenus FSE > Navigation Block: Parent menu items lose typography settings/customization when adding submenus Mar 2, 2023
@cuemarie
Copy link

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple: Replicated
  • Tested on AT: Replicated
  • Tested on Self-hosted: Replicated
  • Replicable on Core? Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated in core - converting a Menu item to a Submenu loses any individual Typography settings on the link.
  • The full Navigation block can still be stylized using Typography, but individual submenu items cannot have their own typography styles the way other menu items can.

Self-Hosted Example

Screen.Capture.on.2023-03-23.at.15-36-24.mov

📌 ACTIONS

@cuemarie cuemarie added Navigation [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Feature] Full Site Editor The site editor. [Platform] Simple [Platform] Atomic labels Mar 23, 2023
@annezazu
Copy link

annezazu commented Sep 3, 2024

I can replicate this! How rough:

replicate.nav.block.parent.mov

@annezazu
Copy link

annezazu commented Sep 5, 2024

PR underway to address this: WordPress/gutenberg#65060 This can be closed out when the PR is merged.

@annezazu
Copy link

Closing this out with the merging of WordPress/gutenberg#65060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. Navigation [Platform] Atomic [Platform] Simple [Pri] Low [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

3 participants