Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The preview of page template picker is not rendered well #69555

Closed
3 of 4 tasks
arthur791004 opened this issue Oct 28, 2022 · 4 comments
Closed
3 of 4 tasks

The preview of page template picker is not rendered well #69555

arthur791004 opened this issue Oct 28, 2022 · 4 comments
Assignees

Comments

@arthur791004
Copy link
Contributor

arthur791004 commented Oct 28, 2022

Referring to p1666257227083559-slack-CRWCHQGUB, the following things are wrong in the preview

Image

  • The site name
  • The site tagline
  • The site logo
  • The style variation

Possible Solutions

  1. Switch to new the new endpoint, /site-previews/pattern, to preview the page templates
  2. Render the page templates on the calypso side

Dev Tasks

@arthur791004 arthur791004 self-assigned this Oct 28, 2022
@arthur791004
Copy link
Contributor Author

Reverted #69283 as it doesn't work on AT sites. See #69553

@arthur791004
Copy link
Contributor Author

arthur791004 commented Oct 28, 2022

Referring to p1666946034895699-slack-C03N25JPCE4, I will hold it on and come back when we have a time.

Here might be possible tech path:

@arthur791004
Copy link
Contributor Author

arthur791004 commented Nov 1, 2022

Here is the demo that renders the page templates via ETK plugin (#69573). If it looks okay, we could go this way 🙂

page-template-demo.mov

cc @simison

@arthur791004
Copy link
Contributor Author

Close it via #69573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant