Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block Mobile Menu in FSE won't work until after all site content has loaded. #63515

Open
KirkwallDay opened this issue May 11, 2022 · 8 comments
Labels
[Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@KirkwallDay
Copy link

Quick summary

The mobile menu on an FSE site will not function until all of the site content is loaded. This is particularly a problem with ads as they generally take a little bit longer to load.

Steps to reproduce

  1. Have an FSE site with Jetpack Ads enabled.
  2. Make sure the site has a mobile menu.
  3. View the site and try to use the mobile menu before the ads load, or even a little bit after the ads load.

What you expected to happen

The mobile menu should open.

What actually happened

The mobile menu is unresponsive and seems to stay that way for a few minutes after the ads load.

Context

5207111-zen

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

I think it's with FSE in general. We tested with Russel and Skatepark

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No but the platform is still usable

Workaround details

No response

@KirkwallDay KirkwallDay added [Type] Bug [Pri] High User Report This issue was created following a WordPress customer report labels May 11, 2022
@Greatdane
Copy link

Some questions;

  1. With Jetpack Ads, do you mean WordAds?
  2. When you say 'Make sure the site has a mobile menu', are you using a classic menu? FSE menus are configured via wp-admin/edit.php?post_type=wp_navigation and as far as I know, you cannot configure a mobile-only? So are we talking about a 'classic menu' that was originally set as a mobile menu?

Thanks!

@KirkwallDay
Copy link
Author

Hey @Greatdane,

With Jetpack Ads, do you mean WordAds?

Yes, that's right.

When you say 'Make sure the site has a mobile menu', are you using a classic menu? FSE menus are configured via wp-admin/edit.php?post_type=wp_navigation and as far as I know, you cannot configure a mobile-only? So are we talking about a 'classic menu' that was originally set as a mobile menu?

In the template editor, you'll need to add a navigation block into your header (although this probably happens anywhere the block is added) and then make sure that it's set to show the mobile menu. The setting is here. "Mobile" and "Always" should re-produce the issue, but with "Mobile" you'll need to view the site on a mobile view.

Screen Shot 2022-05-12 at 8 32 38 AM

@joweber123
Copy link

This looks to be an issue with an ads file that is loading very slowly. I have reached out to see if this is something that we can speed up on our end at all as that is the file that is blocking the other resources from loading here.

pMyNb-5kb-p2_consent-request-loading-time/

@happychait
Copy link

Although ads file is taking time to load, the theme and its menu shouldn't wait for the 3rd party ad server or any other 3rd party request to complete, as discussed in pMyNb-5kb/#comment-16269

So this is nothing to do with ads, and back to the theme's purview.

@jordesign
Copy link
Contributor

To my research - it's definitely the javascript for the menu being blocked until the page load is complete.

This might be theme related - but could also be something that the core Navigation block is doing by default.

@jordesign
Copy link
Contributor

Confirmed this is a bug in Gutenberg itself - so we've not got an open issue for that.
WordPress/gutenberg#41149

@jordesign jordesign added the Triaged To be used when issues have been triaged. label May 19, 2022
@cometgrrl cometgrrl added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Sep 2, 2022
@karenroldan karenroldan added [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Oct 5, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Oct 5, 2023
@cuemarie cuemarie moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 5, 2023
@candy02058912 candy02058912 moved this from Triaged to Needs Core/3rd Party Fix in Automattic Prioritization: The One Board ™ Jul 12, 2024
@candy02058912
Copy link
Contributor

Confirmed that this is still reproducible.
I am setting this issue's priority to Normal to follow the other issues with the status "Needs Core/3rd Party Fix."

Asked about how we can triage core fix issues here: p1720755406642149/1720683311.692079-slack-C01UW7SB411 @Automattic/dotcom-product-ambassadors

@mrfoxtalbot
Copy link

I got back to you in Slack. Apologies for the delay @candy02058912

@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
Status: Needs Core/3rd Party Fix
Development

No branches or pull requests

9 participants