Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: Update the masterbar to change My Site --> My Sites #473

Closed
scruffian opened this issue Nov 23, 2015 · 2 comments
Closed

Signup: Update the masterbar to change My Site --> My Sites #473

scruffian opened this issue Nov 23, 2015 · 2 comments
Assignees
@artpi
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Bug
Milestone
Core: Iteration 17

Comments

@scruffian
Copy link
Member

After creating second site, the masterbar in /me/next still reads "My Site" instead of "My Sites"
https://cloudup.com/c49ibiD8d9Y

After clicking skip it changes to "My Sites"
@scruffian scruffian added [Type] Bug [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Nov 23, 2015
@scruffian scruffian added this to the NUX: Signup: Future milestone Nov 23, 2015
@scruffian scruffian mentioned this issue Nov 23, 2015
Merged
2 tasks
@artpi artpi self-assigned this Nov 25, 2015
@artpi
Copy link
Contributor

artpi commented Nov 25, 2015

Will work on it, since I reported it initially

@artpi
Copy link
Contributor

artpi commented Nov 25, 2015

There definitely is an issue here:
https://cloudup.com/i7stWYLuw3w

The bigger problem seems to be, that Layout actually is never re-rendered when new data is in the store. So the first props stay

@artpi artpi mentioned this issue Nov 26, 2015
Merged
@rralian rralian modified the milestones: Core: Iteration 17, NUX: Signup: Future Nov 30, 2015
@artpi artpi closed this as completed in 5e788eb Nov 30, 2015
@mdno mdno mentioned this issue Nov 5, 2022
Open
@anarh anarh mentioned this issue Nov 5, 2022
Open
@mdno mdno mentioned this issue Dec 25, 2022
Open
@anarh anarh mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artpi artpi

Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Bug
Projects
None yet
Milestone
Core: Iteration 17
Development

No branches or pull requests
3 participants
@rralian @scruffian @artpi