Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: alignment issues #446

Closed
rralian opened this issue Nov 22, 2015 · 3 comments
Closed

Notifications: alignment issues #446

rralian opened this issue Nov 22, 2015 · 3 comments
Labels

Comments

@rralian
Copy link
Contributor

rralian commented Nov 22, 2015

I'm seeing a few issues with notification alignment.

  • The mid-point of the icon does not match the mid-point of the text.
  • Also, where it meets up with the sidebar feels misaligned, as the bottom of the notification is about five pixels off from the top of the site card in the sidebar.

notifications issue 1

  • If you narrow the screen a bit, once you hit a certain breakpoint the notification no longer meets up with the sidebar, but the left edge does not meet up with the left edge of the content. It seems like it should.

notifications issue 2

The first issue requires some css tweaks and testing. My non-designer suggestion for the second two issues is that we just change notification so they no longer meet up with the sidebar at full width and instead just align with the left edge of the content.

@rralian
Copy link
Contributor Author

rralian commented Nov 22, 2015

/cc @mtias @shaunandrews @jasmussen

@shaunandrews
Copy link
Contributor

This is being addressed in #302

@lancewillett
Copy link
Contributor

This has been fixed in design updates to Notices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants