Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts: Poor Preview of Blog Layouts on new sites without any posts #39342

Closed
ianstewart opened this issue Feb 10, 2020 · 11 comments
Closed

Layouts: Poor Preview of Blog Layouts on new sites without any posts #39342

ianstewart opened this issue Feb 10, 2020 · 11 comments

Comments

@ianstewart
Copy link
Contributor

This is a poor example of what a blog post layout could provide.

image

Is it possible to serve up example or placeholder content here to improve the preview? This will likely be something we'll also need to consider in onboarding contexts as well. cc @johnHackworth

@iamtakashi @boonerang @alaczek

@ianstewart
Copy link
Contributor Author

Another example from the Barnsbury Layout.

image

@marekhrabe
Copy link
Contributor

For the preview, we use real block code to render it and it always goes directly to API to get posts.

Adding some sort of override just for the preview, while technically possible, could bring a lot of unnecessary complexity to the block.

I know that in the past, new wpcom sites used to be created with some example posts already posted on a site to prevent this exact situation happening on homepages (it was saying "Nothing here"). Did we stop doing this? Would it be a good idea to bring this back?

What is the priority on this issue? That will help us understand how we can solve this and if any short term compromises need to be done.

@getdave
Copy link
Contributor

getdave commented Feb 27, 2020

We do now have a way to manipulate Blocks going into Preview only if that helps sort this. But it sounds like it could add lots of complexity as well...

@iamtakashi
Copy link
Contributor

I know that in the past, new wpcom sites used to be created with some example posts already posted on a site to prevent this exact situation happening on homepages (it was saying "Nothing here"). Did we stop doing this? Would it be a good idea to bring this back?

I've just tested this by creating some new sites. It seems that we only make some example posts if the site is in the blog segment. So newly created sites in the business and professional segments will have this issue. I wonder if we should make some example posts for those segments as well.

@marekhrabe
Copy link
Contributor

I wonder if we should make some example posts for those segments as well.

I think that would be a good idea. While we can technically solve it in the block, it will be an unprecedented change. All other alterations of blocks in previews are only done by tweaking some of their settings/attributes. Here we would have to update the main block source code to add a specific behavior solely for a preview.

Another thing to look at is that adding example posts to headstart will only fix newly created sites. Is that an acceptable solution?

@alaczek
Copy link
Contributor

alaczek commented Mar 2, 2020

Adding some sort of override just for the preview, while technically possible, could bring a lot of unnecessary complexity to the block.

Would this mean the block would display posts in the preview, but not when the page template was actually applied on a site with no posts? If so, it could be really confusing for the customer.

Another thing to look at is that adding example posts to headstart will only fix newly created sites. Is that an acceptable solution?

Not ideal, but I would say yes - it seems to be a better long term solution. But curious to hear what others think.

@davemart-in
Copy link
Contributor

It looks like we already have a placeholder to put something, it just doesn't look great:

placeholder

As a simple next step, let's just update the design/content of what we're showing in that spot to be something like:

blank-slate

Borrowing styles from the post list blank slate screen:

posts-blank-slate

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@ianstewart
Copy link
Contributor Author

This issue can still be reproduced.

At some point this year we will likely replace all these occurrences with the Query Block (or a Variation of it) — cc @alaczek  — but unsure of the specific timelines beyond that more general one.

@shaunandrews
Copy link
Contributor

The Navigation and Social Icons blocks have a new(-ish) empty state that shows a minimal visual representation of how the block could look once setup:

image

It might make sense to create and render a similar "skeletal" placeholder for the content blocks.

@apeatling
Copy link
Member

I don't think we are going to work on this, and will replace with the Query block, so removing from backlog.

@cuemarie cuemarie closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
@cuemarie cuemarie added the [Closed] Won't Fix No intention to address issue. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants