Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: pages placeholder glitch when offline #358

Closed
rickybanister opened this issue Nov 20, 2015 · 4 comments
Closed

Framework: pages placeholder glitch when offline #358

rickybanister opened this issue Nov 20, 2015 · 4 comments

Comments

@rickybanister
Copy link

To reproduce:

  1. Visit http://calypso.localhost:3000/ or load the Desktop app
  2. Lose your internet connection (or turn off your wifi)
  3. Visit http://calypso.localhost:3000/pages/example.wordpress.com (click on the Pages sidebar link)
  4. Note the crazy flashing between the Pages placeholder and the EmptyContent message

https://cloudup.com/c0B4gJZHOxI

Note that /posts simply displays the EmptyContent message when there is no connectivity. We should standardize how we handle situations when we can't fetch data (no connection) as opposed to having no data to fetch. It could be disconcerting to see the EmptyContent message when using the Desktop app—a user could assume their posts or pages were deleted.

@rralian
Copy link
Contributor

rralian commented Nov 20, 2015

You can reproduce this in production too. Go to the posts page for one of your sites... wordpress.com/posts/example.wordpress.com, turn off your internet, then click on pages.

This is pretty lame. We should fix it very soon. But I don't think it's blocker level.

@rralian rralian added this to the Core: Iteration 17 milestone Nov 30, 2015
@gwwar
Copy link
Contributor

gwwar commented Dec 3, 2015

@rralian @rickybanister is this still an issue? I wasn't able to reproduce the issue on production.
I think it would be nice to also add a disconnected notice somewhere on the page, I'm currently seeing loading placeholders pulsing forever when disconnected.

@rralian
Copy link
Contributor

rralian commented Dec 3, 2015

Yep, definitely still an issue. See video: https://cloudup.com/cbX1saGeMDt

@gwwar gwwar self-assigned this Dec 3, 2015
@gwwar
Copy link
Contributor

gwwar commented Dec 3, 2015

Thanks for the vid! Oddly enough I wasn't able to see the flickering until I turned my connection off, then on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants