Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: hidden post text entry during input #322

Closed
designsimply opened this issue Nov 20, 2015 · 1 comment
Closed

Editor: hidden post text entry during input #322

designsimply opened this issue Nov 20, 2015 · 1 comment
Assignees
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal [Type] Bug
Milestone

Comments

@designsimply
Copy link
Contributor

If your cursor is active in the top part of a post, and you scroll down, it is then out of view. If you start typing in this state you cannot see what is being typed.

What I Did:

  • Scrolled down while drafting a new post (Visual Editor)
  • Typed some post contents
  • Env:
    • Macbook Pro Retina 15" Late 2013
    • Browser: Chrome stable.
    • Resolution: "Default for display"
    • Window "zoomed" full screen

What I Expected:

  • The things I typed to be visible & not obscured by editor chrome
  • If the caret happens to be obscured when entering text, it should bring the insert location into view.

What Actually Happened:

  • When the editor bar becomes fixed, the entry box flows beneath it
  • The top few rows of the input element become obscured
  • The result of typing in this space is only visible once I've scrolled.

Here's a video:
https://cloudup.com/cA2xIIIGbdP

/hat tip jblz for the original report

So expected behavior would be to pad the mce editor so text never hides behind the toolbar?

That would be fine, or scrolling such that the top of the entry box is not obscured when typing otherwise would be, but the padding approach seems easier / to have less edge cases.

From timmyc

Some findings from my testing. The root cause appears to be the fact we scroll a portion of the editor behind the toolbar and masterbar. So the behavior will happen when in the first ~110px top part of the editor.

In the following gif, I keep my cursor on the first line, slowly scroll up and type, and you will notice when I reach the third line - or the point that the editor text region actually scrolls off the top of the browser page, the browser's default behavior kicks in and scrolls the cursor back into view:

scroll

From gwwar

@timmyc scrolling is trigged as a side effect of the mceInsertContent command. Might be worth investigating if adding an after callback or before callback is worth it.

From kelly

[Made] an incremental improvement would be to make the sticky toolbar slightly transparent so you could see that something was happening behind it. It also makes the stickiness more apparent because it adds depth.

transparent

It would be nice if it could act more like Google Docs:

back up

@designsimply designsimply added [Type] Bug [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal labels Nov 20, 2015
@designsimply designsimply added this to the Editor: Next milestone Nov 20, 2015
@alisterscott
Copy link
Contributor

Retested 12 May 2017: no longer an issue: text is bought into focus when typing after scrolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants