Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Move purchases logic in the API #2783

Closed
stephanethomas opened this issue Jan 26, 2016 · 1 comment
Closed

Purchases: Move purchases logic in the API #2783

stephanethomas opened this issue Jan 26, 2016 · 1 comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Status] Stale [Type] Enhancement

Comments

@stephanethomas
Copy link
Contributor

As discussed in #2602 (comment), we shouldn't have that much logic in our purchases functions. To be more specific the logic that determines whether a purchase is cancelable or is removable should live in the API. As such, we should take advantage of the is_cancelable property returned by the endpoint which we don't use at all in Calypso.

We should also take this opportunity to remove any unnecessary property from the purchases assembler such as subscribedDate or tagLine - there is no need to keep them around.

@stephanethomas stephanethomas added [Type] Enhancement [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Jan 26, 2016
@stephanethomas stephanethomas added this to the Amber: Backlog milestone Jan 26, 2016
@fabianapsimoes fabianapsimoes removed this from the Amber: Backlog milestone Jan 29, 2016
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Status] Stale [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants