Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: clean up edit-post folder #26642

Closed
vindl opened this issue Aug 10, 2018 · 3 comments
Closed

Gutenberg: clean up edit-post folder #26642

vindl opened this issue Aug 10, 2018 · 3 comments
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Enhancement [Type] Janitorial

Comments

@vindl
Copy link
Member

vindl commented Aug 10, 2018

In order to get the first version of the Gutenberg shell in Calypso running, we copied most of the edit-post folder components. However, some of these like metaboxes and media library are not actually not needed. For most of the others, we are planning to add Calypso specific implementations (sidebar components).

We need to decide which ones from core we want to keep, and remove the obsolete pieces of functionality from edit-post folder.

The current decision of the core team is that they are not going to publish edit-post as an npm package. We might want to revisit this decision again, or come up with a strategy for maintaining the copied code from Gutenberg master.

@vindl vindl added [Type] Enhancement [Type] Janitorial [Goal] Gutenberg Working towards full integration with Gutenberg labels Aug 10, 2018
@vindl vindl added this to the Calypso Gutenberg Integration milestone Aug 10, 2018
@vindl
Copy link
Member Author

vindl commented Aug 15, 2018

On hold until WordPress/gutenberg#8958 is merged.

@mmtr
Copy link
Member

mmtr commented Oct 25, 2018

Now that the @wordpress/edit-post package is published we can probably import everything from it.

@vindl
Copy link
Member Author

vindl commented Oct 25, 2018

Now that the @wordpress/edit-post package is published we can probably import everything from it.

Started a PR to handle this: #28095.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Enhancement [Type] Janitorial
Projects
None yet
Development

No branches or pull requests

2 participants