-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup: Accessibility fixes #252
Comments
@scruffian is this about the Domain step? |
I believe so. |
I tried reproducing this but seems like it's at least partially fixed if I'm not mistaken. On http://calypso.localhost:3000/start/domains:
I hope this update help to push this forward, or close it :) |
This has been fixed. |
We had someone test the signup flow from an accessibility perspective. @davidakennedy made the following suggestions:
I took a quick look at this. Here are a few spots where we can improve the experience:
This is because the screen shots have no alt attributes, which help describe images to users with assistive technology. See this article for more: http://webaim.org/techniques/alttext/
One way to fix this is adding the theme description as the alt attribute for the theme screenshots. This wouldn't be the perfect alt text for the screenshots, but better than nothing.
There are a few issues here:
div
and the close search button is aspan
. Both of these would work better asbutton
elements since that's the better semantic element, and because of that, various information is communicated to assistive technology APIs. Plus, users hear the words "Close button" so they know they can press it, and something will happen. That's not the case as it is now.label
. This can either be done with a normallabel
element oraria-label
attribute.aria-live
to communicate the info in to users. It could return something like "Five search results" or "No search results, try again. See: http://heydonworks.com/practical_aria_examples/#offline-alert as an example.This is just some of the basics and larger issues that the user was having with the domain page. It's a good place to start.
The text was updated successfully, but these errors were encountered: