Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Rendering: Stub components that depend on component.js #192

Closed
hoverduck opened this issue Nov 19, 2015 · 0 comments
Closed

Comments

@hoverduck
Copy link
Contributor

Including:

  • Dialog

See comment below, and componentjs/component#212.

** Bump click-outside version to 1.0.4 **
The new version uses the full component-event name for that dependency.
Previously, click-outside's package.json had a browser section where
component-event was replaced by an event alias, which was then
used in require statements in the source code. As the alias only
works in the browser but not on the server side, those tests that
indirectly require click-outside needed to mock intermediate dependencies.

This fix should allow dropping component mockery from tests that require
click-outside.
(Unfortunately, they'll still need a DOM stub, and will possibly continue
to need to mock other elements, as there are other dependencies with
problematic browser fields in their package.json files.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants