Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: delete-site-notices are not getting displayed #158

Closed
rralian opened this issue Nov 19, 2015 · 6 comments
Closed

Settings: delete-site-notices are not getting displayed #158

rralian opened this issue Nov 19, 2015 · 6 comments

Comments

@rralian
Copy link
Contributor

rralian commented Nov 19, 2015

There should be feedback that is displayed to the user when they delete a site and are redirected to the all-sites stats page. That stopped working a while ago because the component listening for these actions is no longer contained in the page due to some other changes. This should probably get reworked in general.

@rralian rralian added [Type] Bug [Feature] Site Settings All other general site settings. labels Nov 19, 2015
@rralian
Copy link
Contributor Author

rralian commented Nov 19, 2015

/cc @johnHackworth

@drewblaisdell
Copy link
Contributor

This was fixed by #1246.

@drewblaisdell
Copy link
Contributor

The fix for this in #1246 was reverted with #1318, so I'm reopening this.

@rralian
Copy link
Contributor Author

rralian commented Feb 5, 2016

reopening issue, based on further discussion in #3076

@lancewillett
Copy link
Contributor

During a bug scrub looped back to this open issue. Behavior seems the same — no improvements to the message on the final screen, /stats.

Testing steps:

Starting at /settings/general:
screen shot 2016-05-05 at 16 16 41

Now at /settings/delete-site/:
screen shot 2016-05-05 at 16 16 46

Confirm dialog appears:
screen shot 2016-05-05 at 16 16 54

Confirmed by typing site address:
screen shot 2016-05-05 at 16 17 03

Intermediate feedback appears briefly:
screen shot 2016-05-05 at 16 17 07

Last screen has the missing & final notice (which is what this issue is about):
screen shot 2016-05-05 at 16 17 09

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants