Free Trials: Domain credit shouldn't be usable during the trial period.

[matthusby]

D650-code has a patch that will disable the domain credit during the trial period.

Part of #1484.

Also fixes #1377.

cc @fabianapsimoes @spncrb @drewblaisdell

• Product Review
• Code Review

[ghost]

This patch breaks the /plans page (missing trial buttons):

There are also internal server errors in console:

Was able to verify that it was your patch by removing the patch from the sandbox (buttons re-appear) and re-applying (buttons disappear, errors return)

[ghost]

Just managed to add a trial without the patch and re-add the patch.

The functionality intended does indeed work - no domain credits (charged for domains).

That said, it does break /plans, per above.

[matthusby]

I just updated the diff, there was a fatal error when checking a site that didn't have a plan.

[fabianapsimoes]

Looks good! Here's what I tested:

• we do not display "free with plan" in /domains/add to trials.
• we charge trials correctly for domains.
• after a trial is purchased, we do display "free with plan" in /domains/add.
• we do not charge users who purchased a trial for the bundled domain.
• buttons in /plans are displayed correctly when user has no plan, user has trial, user has plan.

Product 👍

[scruffian]

This was deployed.