Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: show Sharing link in sidebar as disabled until Jetpack options are ready in the UI #1425

Closed
lancewillett opened this issue Dec 9, 2015 · 1 comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. Navigation [Type] Bug When a feature is broken and / or not performing as intended

Comments

@lancewillett
Copy link
Contributor

When viewing a Jetpack site in Calyspo, and you reload the page — the "Sharing" item appears only after a delay because the sidebar needs to check if the feature exists via a network request.

Video: https://cloudup.com/isD6PpBnPDq

Possibly related to #429

Keep the sidebar item in place and handle the checks on the actual render/controller, maybe saying why it's not working and how to enable.

How to solve this? Possibly with a better sync and storage of the active Jetpack options for a given sit.

Why (via @mtias):

The problem is we delay rendering of key interface elements (like the Sharing menu item) because we don’t have information to know whether we should show it or not: is Publicize enabled or disabled?

Which then makes the sidebar jump after a couple seconds... and is an odd interaction. If we fix the jump in some other way — such as showing "Sharing" as disabled until we have the info — that would be a big improvement.

@lancewillett lancewillett added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. Navigation labels Dec 9, 2015
@mtias
Copy link
Member

mtias commented Dec 17, 2015

Fixed by @lezama in #1700. Uruguay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. Navigation [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants