Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Wait for purchases to load before allowing users to delete a site #1110

Closed
scruffian opened this issue Dec 1, 2015 · 0 comments
Closed

Purchases: Wait for purchases to load before allowing users to delete a site #1110

scruffian opened this issue Dec 1, 2015 · 0 comments
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug

Comments

@scruffian
Copy link
Member

In #1063 I noticed that until the purchases for a site have loaded, the user is able to move to the "delete a site" section without being shown the warning about the site having upgrades

We need to prevent users from being able to click this button until the /sites/:siteId/purchases endpoint has loaded.
@scruffian scruffian added [Type] Bug [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Dec 1, 2015
@scruffian scruffian added this to the Purchases: v1 milestone Dec 1, 2015
@scruffian scruffian mentioned this issue Dec 1, 2015
Merged
2 tasks
This was referenced Dec 3, 2015
Closed
Merged
@drewblaisdell drewblaisdell added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2015
@drewblaisdell drewblaisdell removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scruffian @drewblaisdell @fabianapsimoes