Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Editor: Use the SitesDropdown component #100529

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Feb 26, 2025

Related to https://github.com/Automattic/loop/issues/455

Proposed Changes

  • Use the SitesDropdown component for Quick Posts.
Before After
Screenshot 2025-02-26 at 5 34 30 PM Screenshot 2025-02-26 at 5 34 13 PM

Why are these changes being made?

  • The SitesDropdown component has many helpful features built-in to help users find the site they want to post to.
  • We use SitesDropdown in other places, such as /me/account, so reusing it provides a consistent experience.

Testing Instructions

  • Use Calypso Live and go to /reader?flags=reader/quick-post
  • The site selection drop-down should work as it did before, and you should be able to post to your sites using the editor and the "Post" button.
  • Double-check that nothing will leak outside of the feature flag. (It shouldn't)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/quick-post-site-selector on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~425 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader      +1993 B  (+0.1%)     +425 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan changed the title Use the SitesDropdown component Reader Editor: Use the SitesDropdown component Feb 26, 2025
@DustyReagan DustyReagan self-assigned this Feb 26, 2025
@DustyReagan DustyReagan marked this pull request as ready for review February 26, 2025 23:40
@DustyReagan DustyReagan requested a review from a team as a code owner February 26, 2025 23:40
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants