Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting Overview: Fix the renew domain on the Active domains card #100476

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

arthur791004
Copy link
Contributor

Related to #

Proposed Changes

  • Fix the "Renew now" action under the Active domains table doesn't work

Why are these changes being made?

Testing Instructions

  • Go to /sites
  • Select any site that has a expiring domain
  • Click the ... on the Active domain cards
  • Click the Renew now button
  • Ensure it opens the checkout page to renew the domain

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Feb 26, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~337 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-overview      +1569 B  (+0.1%)     +423 B  (+0.1%)
hosting             +361 B  (+0.0%)     +102 B  (+0.0%)
domains             +244 B  (+0.0%)      +76 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Feb 26, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hosting-overview-renew-domain on your sandbox.

@taipeicoder
Copy link
Contributor

Good catch! This fix doesn't seem to work quite right for me. I'm seeing a "Renew now" button that works as intended, but the "Renew now" item from the ellipsis menu is still broken.

Screen.Capture.on.2025-02-27.at.10-16-04.1.mp4

@arthur791004
Copy link
Contributor Author

but the "Renew now" item from the ellipsis menu is still broken.

It should be fixed by f7a8659.

Copy link
Contributor

@lsl lsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action menu takes me to checkout without the error notice or the reload to an empty cart.

@arthur791004 arthur791004 merged commit 08949aa into trunk Feb 27, 2025
13 checks passed
@arthur791004 arthur791004 deleted the fix/hosting-overview-renew-domain branch February 27, 2025 06:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants