-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hosting Overview: Fix the renew domain on the Active domains card #100476
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~337 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Good catch! This fix doesn't seem to work quite right for me. I'm seeing a "Renew now" button that works as intended, but the "Renew now" item from the ellipsis menu is still broken. Screen.Capture.on.2025-02-27.at.10-16-04.1.mp4 |
It should be fixed by f7a8659. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action menu takes me to checkout without the error notice or the reload to an empty cart.
Related to #
Proposed Changes
Why are these changes being made?
Testing Instructions
...
on the Active domain cardsRenew now
buttonPre-merge Checklist