Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit history in UTC maybe inconsistent with other transaction reports #9484

Open
Tracked by #9492
nagpai opened this issue Sep 24, 2024 · 2 comments
Open
Tracked by #9492
Labels
category: core WC Payments core related issues, where it’s obvious. focus: deposits type: bug The issue is a confirmed bug.

Comments

@nagpai
Copy link
Contributor

nagpai commented Sep 24, 2024

Describe the bug

The dates currently shown in the Deposit history is calculated based on UTC time zone. This may cause confusion for merchants since the transactions list is shown with the store timezone time stamps.

Testing instructions

TBA

Notes

@nagpai nagpai added type: bug The issue is a confirmed bug. category: core WC Payments core related issues, where it’s obvious. focus: deposits labels Sep 24, 2024
@vbelolapotkov
Copy link
Collaborator

Hey @nagpai, I'm wondering why this one is labeled as bug? So far looks like enhancement, and I suppose it's been discussed with a product team?

@nagpai nagpai changed the title Deposit history date needs to be based on store time zone Deposit history in UTC maybe inconsistent with other transaction reports Sep 25, 2024
@nagpai
Copy link
Contributor Author

nagpai commented Sep 25, 2024

Hi @vbelolapotkov, I have marked it as a bug since it can cause confusion for merchants, and it is inconsistent with how we show dates in the store time zone for Transactions list.

I suppose it's been discussed with a product team?

Yes, Sourav has confirmed that we should be using the store time zone. As indicated in @haszari 's comment though, we will need to do an audit to see how date and time is calculated by various reports within WooPayments, and make it consistent. I have amended the title and the content of the issue to indicate why it is a bug ( what could go wrong for merchants )

I created this issue, and another similar one related to Disputes as placeholders for now. My broad understanding - Depending on the approach we take, we may either close this or add this as a task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. focus: deposits type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants