Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying V2 card styles to V1 element: Card brand icons on radio button #9475

Closed
FangedParakeet opened this issue Sep 20, 2024 · 4 comments · Fixed by #9483
Closed

Applying V2 card styles to V1 element: Card brand icons on radio button #9475

FangedParakeet opened this issue Sep 20, 2024 · 4 comments · Fixed by #9483
Assignees
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.

Comments

@FangedParakeet
Copy link
Contributor

FangedParakeet commented Sep 20, 2024

Description

Part of #9331

This is an incremental issue is to add card brand icons from V2 to the payment gateway radio button at checkout in V1. We should also remove existing brand icons from the card number input field. This applies to both shortcode and blocks just the blocks checkouts.

Card brand icons
Card brand icons placement

Please find designs linked below in relevant P2. Card brand icons component should already exist in V2: if possible, we would like to reuse it here.

Designs

pfHfG4-gT-p2#comment-211

Additional context

pfHfG4-gT-p2#comment-211

@FangedParakeet FangedParakeet added type: enhancement The issue is a request for an enhancement. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. focus: checkout payments labels Sep 20, 2024
@gpressutto5 gpressutto5 self-assigned this Sep 20, 2024
@FangedParakeet
Copy link
Contributor Author

Please add your planning poker estimate with Zenhub @gpressutto5

@gpressutto5
Copy link
Contributor

@FangedParakeet @pierorocca The brand icons on the input are updated dynamically to show which card brand is being used. Should we remove that?

image image image

This is also used to select the preferred brand when a cobadged card is used.
Stripe does not provide an option to hide that, and the Appearance API can't affect those. If we decide to go ahead with the change I'll ask if that's possible in the Stripe Discord server.

@pierorocca
Copy link
Contributor

pierorocca commented Sep 23, 2024

Hey guys, Stripe hasn't enabled us yet to remove the animated logos from the card number field. They're supposed to provide an update on timing but the backup plan for now is #9331 (comment). They will have an option for us by end of year I just don't know when exactly and there's a chance it could be part of a larger Stripe redesign effort that they have going on.

@gpressutto5
Copy link
Contributor

Oh, I missed that, thanks @pierorocca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants