Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google & Apple Pay buttons are displayed in editor even when the payment method is disabled #9444

Closed
alexflorisca opened this issue Sep 16, 2024 · 5 comments · Fixed by #9646
Assignees
Labels
focus: checkout payments good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@alexflorisca
Copy link
Member

alexflorisca commented Sep 16, 2024

Describe the bug

The Google & Apple Pay buttons are displayed in editor even when the payment method is disabled in WooPayments settings.

To Reproduce

  1. In wp-admin, go to WooCommerce > Settings > Payments > WooPayments page
  2. Disable Apple / Google Pay
  3. Open the checkout page in the editor
  4. See that the Apple & Google pay buttons are still rendered in the editor

Actual behavior

The Apple and Google Pay buttons are visible in the editor when they are disabled in settings.

Screenshots

Expected behavior

The Apple and Google Pay buttons should not be visible in the editor when they are disabled in settings.

Potential solution

We should only call registerExpressPaymentMethod if it is enabled from the WooPayments settings page

@alexflorisca alexflorisca added the type: bug The issue is a confirmed bug. label Sep 16, 2024
@c-shultz c-shultz added the good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Sep 18, 2024
@CodingWithError
Copy link

hey can you give more clarification on this i am unable to find a settings page on the main website

@pierorocca pierorocca added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Sep 23, 2024
@alexflorisca
Copy link
Member Author

alexflorisca commented Oct 9, 2024

hey can you give more clarification on this i am unable to find a settings page on the main website

I've edited the steps to reproduce above to be a bit clearer. Let me know if you still have an issue to reproduce. Perhaps the following video is also useful

Screen.Recording.2024-10-09.at.15.21.20.mov

@CodingWithError
Copy link

Assign this to me I will try to work on this.

@gpressutto5
Copy link
Contributor

Hi @CodingWithError, thanks for your interest in helping. Do you still plan on working on this issue? If not, I'll assign it to myself.

@gpressutto5
Copy link
Contributor

Please add your planning poker estimate with Zenhub @FangedParakeet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants