Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Replace intl-tel-input input with Calypso phone input component #4718

Closed
mordeth opened this issue Sep 8, 2022 · 4 comments
Closed
Assignees
Labels
category: engineering For product engineering, architecture work, tech debt and so on. component: accounts Issues related to Accounts focus: account lifecycle

Comments

@mordeth
Copy link
Contributor

mordeth commented Sep 8, 2022

Description

This spike evaluates the benefit of replacing the intl-tel-input phone input library with the Calypso phone input component in favor of bundle size.

@mordeth mordeth self-assigned this Sep 8, 2022
@haszari haszari added the focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). label Mar 11, 2024
@vbelolapotkov vbelolapotkov added component: accounts Issues related to Accounts focus: account lifecycle and removed focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). labels Apr 4, 2024
@vbelolapotkov
Copy link
Collaborator

@anu-rock @timmy5685 routing this one to you since telephone input is used in account settings.

@vbelolapotkov vbelolapotkov added the category: engineering For product engineering, architecture work, tech debt and so on. label Apr 4, 2024
@anu-rock
Copy link
Contributor

anu-rock commented Apr 5, 2024

I think this issue can be closed as it was fixed by #7611 which uses a new telephone input component added in WooCommerce via woocommerce/woocommerce#40335. Pinging the issue author @mordeth to verify and close as needed.

@mordeth
Copy link
Contributor Author

mordeth commented Apr 5, 2024

Indeed, this spike can be closed as it is no longer relevant. Nevertheless, I've identified two instances in the code where 'intl-tel-input' is still being utilized, and we may consider replacing it with woocommerce/woocommerce#40335.

@mordeth
Copy link
Contributor Author

mordeth commented Apr 5, 2024

A new issue, #8581, has been opened to remove all occurrences of intl-tel-input.

@mordeth mordeth closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engineering For product engineering, architecture work, tech debt and so on. component: accounts Issues related to Accounts focus: account lifecycle
Projects
None yet
Development

No branches or pull requests

4 participants