Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia: Resized images larger than their container look as large as the container on the front end #1414

Closed
Copons opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
[Theme] Varia [Type] Bug Something isn't working

Comments

@Copons
Copy link
Contributor

Copons commented Sep 20, 2019

Originally reported here: Automattic/wp-calypso#36026 (review)

Steps to replicate

  • Activate Varia.
  • Insert an image without alignment settings.
  • Manually resize the image as large as possible.
  • Save and preview.

Screenshot 2019-09-20 at 11 26 01

(Please note that the overflowing image has been already reported, and it's unrelated to this issue: #1101)

Result

  • The image is as large as its container.

Screenshot 2019-09-20 at 11 26 22

Expected

  • The image is as large as large as I've resized it.

It might be as easy as having max-width: none (instead of 100%) on .is-resized images. 🤔

@Copons Copons added [Type] Bug Something isn't working [Theme] Varia labels Sep 20, 2019
@allancole allancole self-assigned this Sep 25, 2019
@allancole
Copy link
Contributor

Seems like a bit of an edge case, but one worth fixing :-)
Interesting, I’ll take a look and see if I can replicate.

@iamtakashi
Copy link
Contributor

I'd say the theme behaviour is correct. Users should not be able to make an image larger than the block. And this is an image block bug that has been reported. WordPress/gutenberg#12168

Based on this, I'd close this as a theme issue. Please reopen if we don't agree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Varia [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants