Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation on win7x64 failes with iojs v1.5.1 #2057

Closed
ghost opened this issue Mar 17, 2015 · 7 comments · Fixed by socketio/engine.io#330
Closed

installation on win7x64 failes with iojs v1.5.1 #2057

ghost opened this issue Mar 17, 2015 · 7 comments · Fixed by socketio/engine.io#330

Comments

@ghost
Copy link

ghost commented Mar 17, 2015

Hi,

I tried to install webpack-dev-server but it failed when socket.io is being compiled by VS.

C:\projects\javascript\products\ps.web\node_modules\webpack-dev-server\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\nan.h(409): error C2039: 'ExternalAsciiStringResource' : is not a member of 'v8::String' [C:\projects\javascript\products\ps.web\node_modules\webpack-dev-server\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\build\bufferutil.vcxproj]
          C:\Users\denny.trebbin\.node-gyp\1.5.1\deps\v8\include\v8.h(1889) : see declaration of 'v8::String'
C:\projects\javascript\products\ps.web\node_modules\webpack-dev-server\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\nan.h(409): error C2065: 'ExternalAsciiStringResource' : undeclared identifier [C:\projects\javascript\products\ps.web\node_modules\webpack-dev-server\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\build\bufferutil.vcxproj]

https://gist.github.com/fibric/13590b6b3a0dedae4d74

visual studio express 2012 is installed as well as python 2.7.9

@ghost
Copy link
Author

ghost commented Mar 18, 2015

As mentioned in socketio/engine.io-client#376 its enough to update ws module.
That is what I did manually.

cd node_modules\browser-sync\node_modules\socket.io\node_modules\engine.io\node_modules
npm install ws@latest

and

cd node_modules\browser-sync\node_modules\socket.io\node_modules\socket.io-client\node_modules\engine.io-client
npm install ws@latest

its dirty but it works for now.

@lygstate
Copy link

This should not be closed, socket.io-client doesn't compiled with iojs 2.1.0

@robtayl0r
Copy link

Is this fixed?

@op1ekun
Copy link

op1ekun commented Nov 12, 2015

Nope it's not...

...\node_modules\karma\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\na
n.h(409): error C2039: 'ExternalAsciiStringResource': is not a member of 'v8::String'

i'm running npm install karma.

This happens on windows 10 and node 4.2.0

@lygstate
Copy link

It;s seems to be fixed, use a stable one.

@op1ekun
Copy link

op1ekun commented Nov 13, 2015

Stable what?

I just forked another repository which has socket.io-client dependency:

...node_modules\webpack-dev-server\node_modules\socket.io-client\node_modules\engine.io-client\node_modules\ws\node_modules\bufferutil\build\bufferutil.vcxproj(20,3): error MSB4019: The imported project "C:\Program
Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V110\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.

and

gyp ERR! build error
gyp ERR! stack Error: `msbuild` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (c:\bin\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "node" "c:\\bin\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd c:\dev\playground\gremlins\node_modules\webpack-dev-server\node_modules\socket.io-client\node_modules\engine.io-client\node_modules\ws\node_modules\bufferutil
gyp ERR! node -v v0.12.7
gyp ERR! node-gyp -v v2.0.1
gyp ERR! not ok
npm WARN optional dep failed, continuing [email protected]
npm WARN optional dep failed, continuing [email protected]

Doesn't look like fixed to me... :(

I have already tried ws method and I still see the issue.
However I managed to fix my issue with npm install karma
karma-runner/karma#1691

@nhhockeyplayer
Copy link

I have to bite my tongue when stumbling on these... its frustrating

the issue being, you cut pasted something into your package.json

for me it was one of these out of date
"http-server": "^0.8.5",
"jasmine": "2.3.2",
"karma": "^0.12.23",
"karma-chrome-launcher": "^0.1.4",
"karma-cli": "^0.0.4",
"karma-jasmine": "^0.3.6",
"rimraf": "^2.4.3"

  1. I zapped my node_modules dir
  2. installed each one of these individually
  3. then did npm install for the rest

it built fine

A developer can induce his own transient dependency via cut and paste... and these can be very aggravating aside from many other twists of the new way of doing things.

  • cheers friend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@lygstate @op1ekun @robtayl0r @nhhockeyplayer and others