Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom sheet fragment is broken with unbounded content #3519

Open
1 task done
MiSikora opened this issue Jan 30, 2025 · 0 comments
Open
1 task done

Bottom sheet fragment is broken with unbounded content #3519

MiSikora opened this issue Jan 30, 2025 · 0 comments
Labels
[Area] Android 15 [Priority] Low A less urgent issue that can be addressed when time allows [Type] Bug Not functioning as intended.

Comments

@MiSikora
Copy link
Contributor

Description

After Android 15 migration couple of things in the BaseDialogFragment broke.

Full-screen display

When the content has an unbounded height, the sheet is displayed in full-screen mode instead of being padded at the top. Additionally, the content exhibits a slight parallax effect. See the video below—you can notice how the bottom icons move faster than the rest of the content. Also, observe that the top edge has rounded corners up to a certain point.

bottom-sheet.mp4

Theming

This issue is somewhat related to the previous one. Setting the navigation bar and status bar tint no longer works; everything is now controlled through the background tint. If I force the background tint to red in the previous example, the screen appears as shown in the video below. This also makes it more evident what triggers the parallax effect and the top edge issue.

bottom-sheet-highlight.mp4

Step-by-step reproduction instructions

  1. Go to any episode.
  2. Share it.
  3. Notice bottom sheet behavior.

Screenshots or screen recording

No response

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

No response

@MiSikora MiSikora added [Area] Android 15 [Priority] Medium Not urgent but should be prioritised soon [Type] Bug Not functioning as intended. labels Jan 30, 2025
@MiSikora MiSikora self-assigned this Jan 30, 2025
@MiSikora MiSikora changed the title Bottom sheet fragment is broken Bottom sheet fragment is broken with unbounded content Jan 30, 2025
@MiSikora MiSikora added [Priority] Low A less urgent issue that can be addressed when time allows and removed [Priority] Medium Not urgent but should be prioritised soon labels Jan 30, 2025
@MiSikora MiSikora removed their assignment Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Android 15 [Priority] Low A less urgent issue that can be addressed when time allows [Type] Bug Not functioning as intended.
Projects
None yet
Development

No branches or pull requests

1 participant