Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpress dependencies #855

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Update wordpress dependencies #855

merged 3 commits into from
Sep 2, 2021

Conversation

noahtallen
Copy link
Member

@noahtallen noahtallen commented Sep 2, 2021

All Submissions:

Changes proposed in this Pull Request:

  • Update WordPress packages
  • Update React to v17
  • Update linter packages
  • Fix reported lint errors/warnings

This PR is motivated by our updates to react and wp over at wp-calypso (and ETK/wpcom). yarn really likes all peer dependencies being resolved. :)

How to test the changes in this Pull Request:

  • CI should pass
  • Smoke test

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@noahtallen noahtallen self-assigned this Sep 2, 2021
@@ -16,6 +16,7 @@ import {
Spinner,
ToggleControl,
Toolbar,
// eslint-disable-next-line @wordpress/no-unsafe-wp-apis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we wouldn't import this package, but that's out of scope for this PR

@scinos
Copy link
Contributor

scinos commented Sep 2, 2021

Package-wise it makes sense to me, but I haven't tested the functionality.

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @noahtallen! Did functional testing for all blocks and didn't see anything unexpected.

@noahtallen noahtallen merged commit 081a814 into master Sep 2, 2021
@noahtallen noahtallen deleted the update/wp-deps branch September 2, 2021 22:47
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.37.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants