feat(model): make bulkWrite results include MongoDB bulk write errors as well as validation errors
#15271
+89
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs as well as validation errors Fix #15265
AbdelrahmanHafez
approved these changes
Feb 24, 2025
hasezoey
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15265
Summary
When we return
mongoose.resultsproperty frombulkWrite(), the results property doesn't currently include any MongoDB write errors that occurred. That makes it a multi-step process to determine whether a given bulk write operation succeeded or failed.This is more consistent with how
insertMany()handles errors:insertMany()already adds write errors toresults. However,insertMany()has some logic where it modifies the WriteError's index, which we should consider removing because that makes the result not an instance of MongoDB'sWriteErrorclass.Examples