Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Form: move away from onSplit prop #38031

Closed
Tracked by #36721
jeherve opened this issue Jun 25, 2024 · 0 comments · Fixed by #38246
Closed
Tracked by #36721

Contact Form: move away from onSplit prop #38031

jeherve opened this issue Jun 25, 2024 · 0 comments · Fixed by #38246
Assignees
@monsieur-z
Labels
[Feature] Contact Form [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jun 25, 2024

RichText’s optional onSplit prop was deprecated and replaced with a block.json support key called splitting.

We still use the prop here:

jetpack/projects/packages/forms/src/blocks/contact-form/components/jetpack-field-option.js

Line 53 in 40a8492

onSplit={ handleSplit }

Related PR: WordPress/gutenberg#54543

@monsieur-z already tackled related changes in #37739.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form [Pri] Normal labels Jun 25, 2024
@jeherve jeherve mentioned this issue Jun 25, 2024
Closed
@monsieur-z monsieur-z mentioned this issue Jul 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieur-z monsieur-z

Labels
[Feature] Contact Form [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forms: remove onSplit in favor of splitting feature Automattic/jetpack
2 participants
@jeherve @monsieur-z