Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: investigate how to integrate the VideoPress into the Inserter Media tab #28651

Open
nunyvega opened this issue Jan 30, 2023 · 10 comments
Assignees
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Pri] Normal

Comments

@nunyvega
Copy link

Investigate how to best integrate VideoPress into the new Inserter media tab

One possibility could be something like this, similar to the Video option but with VideoPress videos:
Image

This screenshot is only an idea, we will want first to understand the best way to integrate VideoPress into this new tab.

@nunyvega nunyvega changed the title VideoPress: investigate how to integrate the VideoPress in the Inserted Media tab VideoPress: investigate how to integrate the VideoPress into the Inserted Media tab Jan 30, 2023
@jeherve jeherve added the [Feature] VideoPress A feature to help you upload and insert videos on your site. label Jan 31, 2023
@lhkowalski
Copy link
Contributor

lhkowalski commented Jan 31, 2023

We can get the nightly build of gutenberg from this link: https://gutenbergtimes.com/need-a-zip-from-master/#nightly

@nunyvega
Copy link
Author

Task in 1200913650729635-as-1203867739511986

@lhkowalski
Copy link
Contributor

The PR that inserted the Openverse integration is helpful to understand how to go beyond the 3 pre-defined categories (images, audio, video): WordPress/gutenberg#46251

@courtneyr-dev
Copy link

Can VideoPress allow users to embed from a different VideoPress library? Use case: Embed from WPTV onto LearnWP using chapters that VideoPress now supports. cc: @jonathanbossenger

@Copons
Copy link
Contributor

Copons commented Feb 7, 2023

👋 Hi there!
Just chiming in because @Automattic/t-rex has been tasked to add Pexels and Google Photos to the Media tab: Automattic/wp-calypso#71232

We haven't started looking at it just yet, and we were undecided whether front-loading an exploration (that might help direct Core Gutenberg's API) or waiting for Core Gutenberg to deliver extension points (which might not happen before Core 6.2 is released).

Since we are probably looking at the same thing, just with different file types, I wonder if you have made any progress on this issue.

@lhkowalski lhkowalski changed the title VideoPress: investigate how to integrate the VideoPress into the Inserted Media tab VideoPress: investigate how to integrate the VideoPress into the Inserter Media tab Feb 13, 2023
@lhkowalski
Copy link
Contributor

Hi @Copons!

I wonder if you have made any progress on this issue

We did some exploration on this (pe4Cmx-LC-p2) but got to the same point that you:

The main blocker for doing this is that the categories for the Inserter Media tab will be locked and not extendable on the first release of the feature [...] so we still can’t hook on the code points cited above.

[...] to make this project possible in the near future, the next step is to work with Matías and Nikos on a way to add extendability to the new Media tab, using the VideoPress as a concrete case to drive the development.

We imagined we could help the Gutenberg team on this using the VideoPress use case as an example, like you said, front-load the exploration. We even created some issues for this work here on GitHub, but this is not the highest priority for the @Automattic/jetpack-agora team, for now.

I think it would be lovely to see @Automattic/t-rex working on this, and we can help with any input from our specific use case that you may need.

@Copons
Copy link
Contributor

Copons commented Feb 13, 2023

Cool!

It's not our highest priority either, since we are on other projects currently, and we can afford to keep it on the back-burner for a while longer. I'll note this issue and the exploration post on our PT, and we'll see who get there first!
I'll be off for sabbatical in 2 weeks, but will make sure the team is aware of this and will align with y'all to avoid duplicated work. ✨

@lhkowalski
Copy link
Contributor

Perfect!

@github-actions
Copy link
Contributor

This issue has been marked as stale. This happened because:

  • It has been inactive for the past 6 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@jeherve
Copy link
Member

jeherve commented Oct 18, 2024

I'll reopen this if that's okay with you, since it's still an ongoing issue.

@jeherve jeherve reopened this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Pri] Normal
Projects
None yet
Development

No branches or pull requests

6 participants