From 18373919b85db2e34d7f3febe099b099af2cab65 Mon Sep 17 00:00:00 2001 From: hippietrail Date: Mon, 10 Feb 2025 01:02:02 +0800 Subject: [PATCH] chore: Improve message for capitalizing pronoun I Old message was "First-person singular pronouns must be capitalized." But English has two first-person singular pronouns: I & me. Only I is capitalized. I changed the message to "The first-person singular subject pronoun must be capitalized." "I" is also called the nomininative. I chose "subject" because it's a little less jargony for people less familiar with grammar and linguistics, and it's shorter when the message is already long. --- harper-core/src/linting/capitalize_personal_pronouns.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/harper-core/src/linting/capitalize_personal_pronouns.rs b/harper-core/src/linting/capitalize_personal_pronouns.rs index bd609b99..dc50e324 100644 --- a/harper-core/src/linting/capitalize_personal_pronouns.rs +++ b/harper-core/src/linting/capitalize_personal_pronouns.rs @@ -25,7 +25,8 @@ impl Linter for CapitalizePersonalPronouns { span: tok.span, lint_kind: LintKind::Capitalization, suggestions: vec![Suggestion::ReplaceWith(vec!['I'])], - message: "First-person singular pronouns must be capitalized.".to_string(), + message: "The first-person singular subject pronoun must be capitalized." + .to_string(), priority: 31, }); }