Add amp-live-list comments #909

DavidCramer · 2018-01-26T13:47:07Z

Decide on whether to enforce div container instead of ol. Ideal is ol.
Figure out how to reset form after submission.
Triggering an update does not force a request to update. In short term, just show message saying it will be available soon.
Page without comments does not output an amp-live-list to start with.
Admin notice on the discussion settings screen to indicate that comments in ascending order is not supported yet.

Fixes #862.
Fixes #797.

westonruter · 2018-01-26T19:03:15Z

As discussed, to fully support comments in the AMP plugin for WordPress, the amp-live-list component really needs to support the sort order, but it is not yet: ampproject/amphtml#5396

The ordering of WP comments is configurable in the admin:

For the immediate term we'll be forcing the option to be “newer” and display a notice:

So when amp theme support is present, we'll need to add a filter for option_comment_order to have it return 'desc'. And then some JS will need to be injected onto the Discussion admin screen to disable the select#comment_order element and then to inject the following HTML at the end of its containing fieldset:

<div class="notice notice-info inline"><p><?php echo wp_kses_post( __( 'Note: AMP does not yet <a href="https://github.com/ampproject/amphtml/issues/5396" target="_blank">support ascending</a> comments with newer entries appearing at the bottom.', 'amp' ) ); ?></p></div>

…dd/amp-live-list-comments

westonruter · 2018-01-26T20:33:34Z

amp.php

+ * @param string $message The error message to send.
+ */
+function amp_send_error_json( $message ) {
+	header( 'HTTP/1.1 400 BAD REQUEST' );


You can use status_header( 400 ) instead.

westonruter · 2018-01-26T20:34:31Z

amp.php

+ */
+function amp_send_error_json( $message ) {
+	header( 'HTTP/1.1 400 BAD REQUEST' );
+	wp_send_json( array( 'error' => strip_tags( $message, 'strong' ) ) );


No need to strip_tags() here, as amp-mustache will escape properly and allow formatting as may be desired.

@westonruter I used striptags because amp-mustache takes the text from element so it doesn't go deeper. meaning that anything within child elements are totally removed. So <p><strong>ERROR</strong>:Comment is empty.</p> becomes :Comment is empty
I think we could get all the basic formatting tags in a striptags. Which should work.

Great to know. Thanks for sharing.

westonruter · 2018-01-26T20:39:27Z

amp.php

+ */
+function amp_send_error_json( $message ) {
+	header( 'HTTP/1.1 400 BAD REQUEST' );
+	wp_send_json( array( 'error' => strip_tags( $message, 'strong' ) ) );


Note that a WP_Error instance can be passed to wp_die(), so that needs to be accounted for.

westonruter · 2018-01-26T20:42:09Z

amp.php

+
+	// Add amp comment hooks.
+	add_filter( 'comment_post_redirect', 'amp_comment_post_handler', PHP_INT_MAX, 2 );
+	add_filter( 'wp_die_handler', 'amp_set_comment_submit_die_handler' );


Now that PHP 5.3 is the minimum requirement, we can use closures here to prevent the proliferation of one-liner functions. So this can be:

add_filter( 'wp_die_handler', function() { return function( $error ) { status_header( 400 ); if ( is_wp_error( $error ) ) { $error = $error->get_error_message(); } wp_send_json( compact( 'error' ) ); }; } );

awesome! I forgot that the min version was increased. great news!

westonruter · 2018-01-26T20:42:33Z

amp.php

+function amp_hook_comments_maybe() {
+
+	$method        = filter_input( INPUT_SERVER, 'REQUEST_METHOD', FILTER_SANITIZE_STRING );
+	$is_amp_submit = filter_input( INPUT_GET, '__amp_source_origin', FILTER_VALIDATE_URL );


Let's opt to use $_SERVER and $_GET to facilitate unit testing.

westonruter · 2018-01-26T21:11:15Z

includes/class-amp-comment-walker.php

+
+		$args = array_slice( func_get_args(), 4 );
+
+		$output  = '<amp-live-list layout="container" data-poll-interval="15000" data-max-items-per-page="20" id="amp-live-comments-list">';


The id should probably be unique. It's possible that more than one comment loop could be displayed on a page. So there should perhaps be a new static member variable that increments as the method is called.

Good point! will address it.

Actually, probably should use the post ID in the id here, as otherwise there could be problems with pagination.

Was thinking the same thing. Will experiment and on it.

westonruter · 2018-01-26T21:11:31Z

includes/class-amp-comment-walker.php

+	 * @return string XHTML of the specified page of elements.
+	 */
+	public function paged_walk( $elements, $max_depth, $page_num, $per_page ) {
+		if ( empty( $elements ) || $max_depth < - 1 ) {


Trivial: Remove space between - and 1

westonruter · 2018-01-26T21:12:31Z

includes/class-amp-theme-support.php

+		$amp_walker     = new AMP_Comment_Walker();
+		$args['walker'] = $amp_walker;
+		// @todo Make threaded work by setting 'data-update-time' of the parent first level parent with the last timestamp.
+		$args['max_depth'] = 1;


Yeah, we need to be able to remove this constraint.

Ye, this is temporary, I figured out how to do it. will experiment and make it work!

westonruter · 2018-01-26T21:13:19Z

amp.php

+/**
+ * Hook into a comment submission if an AMP xhr post request.
+ */
+function amp_hook_comments_maybe() {


Rename this to amp_handle_comment_post.

westonruter · 2018-01-26T21:15:04Z

amp.php

+function amp_hook_comments_maybe() {
+
+	$method        = filter_input( INPUT_SERVER, 'REQUEST_METHOD', FILTER_SANITIZE_STRING );
+	$is_amp_submit = filter_input( INPUT_GET, '__amp_source_origin', FILTER_VALIDATE_URL );


The variable name here implies it is a boolean. Let's change it to $amp_source_origin

DavidCramer · 2018-01-27T06:32:08Z

@westonruter Thanks for the thorough review. Good suggestions made. Will work on these and update promptly. Thanks!

DavidCramer · 2018-01-30T13:36:26Z

assets/js/amp-admin-comments.js

+		}
+	} );
+
+})( jQuery );


@westonruter I think this could easily have been a simple inline script alongside the notice, but I made it a asset file for now, just in case.

Thanks. I've decided to go ahead and inline it. See 310a74a

Perfect. thought that would be the case. thanks for sorting it for me.

DavidCramer · 2018-01-30T15:03:48Z

@westonruter You can review this again now I think I have addressed all issues as well as made changes necessary for xwp/ampnews#52

DavidCramer · 2018-01-31T05:29:06Z

includes/class-amp-theme-support.php

+	 * @param string $text           Cancel comment reply link text.
+	 * @return string Cancel reply link.
+	 */
+	public function filter_cancel_comment_reply_link( $formatted_link, $link, $text ) {


@westonruter should be a static function.

Also fix php notices regarding undefined pagenow var and pass var by ref

Remove unused amp_comments_order_disable_scripts() function.

@todo

And test all of its methods. @todo: tests for remaining methods in PR #909.

@todo

And test all of its methods. @todo: tests for remaining methods in PR #909.

Issue #868: Add Comment Unit Tests for PR #909

DavidCramer added 5 commits January 26, 2018 14:13

add amp comment walker

bf03e0f

add amp comment walker to autoloader

9a9b1c3

add comments sanitiser

5f004e8

add comment walker

82162c3

add comment and form sanitizers

04eebf6

DavidCramer requested a review from westonruter January 26, 2018 13:47

DavidCramer added 5 commits January 26, 2018 15:51

correct ID's and max items limit

80feeed

fix new line issue

396aa91

Add form posting handler

1d8728a

rename some methods and add walker depth.

b2577c2

alternate way to get timestamp

87c46b6

Merge branch 'develop' of https://github.com/Automattic/amp-wp into a…

0822a34

…dd/amp-live-list-comments

westonruter requested changes Jan 26, 2018

View reviewed changes

westonruter mentioned this pull request Jan 27, 2018

Create static comments section of single post. xwp/ampnews#24

Closed

DavidCramer added 7 commits January 30, 2018 08:32

wip - walker changes.

dffb7ca

Rework submission handling

98fee1b

Remove uneeded function

014807d

merge develop

ae13421

remove duplicate form sanitizer entry.

646debb

remove amp markup from walker

4b38a5b

Lockdown sort direction and admin notice stating unsupported.

63d83d0

DavidCramer commented Jan 30, 2018

View reviewed changes

westonruter added 3 commits January 30, 2018 13:48

Opt to inline the descending-ordering comment logic since temporary

310a74a

Fix script tag generation for amp-mustache as custom-template

5ee1709

Implement form reset after comment submission via amp-bind and amp-state

8f1b37c

westonruter force-pushed the add/amp-live-list-comments branch from 9e7e6ea to 8f1b37c Compare January 30, 2018 23:41

Disable comment input fields during submission

82e5218

westonruter added 2 commits January 30, 2018 17:07

Fix construction of attributes in comment wrapper elements

91b0c8d

Power comment replies with amp-state

77dc127

DavidCramer commented Jan 31, 2018

View reviewed changes

Show who the commenter is replying to

ef0e4c3

westonruter changed the title ~~[WIP] - Add amp-live-list comments~~ Add amp-live-list comments Jan 31, 2018

westonruter added 2 commits January 30, 2018 21:50

Fix setting initial replyToName state

28d760c

Also fix php notices regarding undefined pagenow var and pass var by ref

Move function with closures out of amp.php for sake of PHP 5.2 check

8b2232f

Remove unused amp_comments_order_disable_scripts() function.

westonruter approved these changes Jan 31, 2018

View reviewed changes

westonruter mentioned this pull request Jan 31, 2018

Add test coverage for (canonical) theme support #868

Closed

westonruter added this to the v0.7 milestone Jan 31, 2018

westonruter merged commit ae997c4 into develop Jan 31, 2018

westonruter deleted the add/amp-live-list-comments branch January 31, 2018 06:04

westonruter mentioned this pull request Jan 31, 2018

Update comments template for amp-live-list xwp/ampnews#52

Merged

kienstra pushed a commit that referenced this pull request Mar 29, 2018

Add test class for AMP_Comment_Walker.

cee8848

And test all of its methods. @todo: tests for remaining methods in PR #909.

kienstra pushed a commit that referenced this pull request Mar 30, 2018

Add test class for AMP_Comment_Walker.

a191066

And test all of its methods. @todo: tests for remaining methods in PR #909.

kienstra mentioned this pull request Mar 30, 2018

Issue #868: Add Comment Unit Tests for PR #909 #1049

Merged

westonruter added a commit that referenced this pull request Apr 3, 2018

Merge pull request #1049 from Automattic/add/868-comments-unit-tests

4848408

Issue #868: Add Comment Unit Tests for PR #909

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add amp-live-list comments #909

Add amp-live-list comments #909

DavidCramer commented Jan 26, 2018 •

edited by westonruter

Loading

westonruter commented Jan 26, 2018

westonruter Jan 26, 2018

westonruter Jan 26, 2018

DavidCramer Jan 30, 2018 •

edited

Loading

westonruter Jan 30, 2018

westonruter Jan 26, 2018

westonruter Jan 26, 2018

DavidCramer Jan 27, 2018

westonruter Jan 26, 2018

westonruter Jan 26, 2018

DavidCramer Jan 27, 2018

westonruter Jan 27, 2018

DavidCramer Jan 27, 2018

westonruter Jan 26, 2018

westonruter Jan 26, 2018

DavidCramer Jan 27, 2018

westonruter Jan 26, 2018

westonruter Jan 26, 2018

DavidCramer commented Jan 27, 2018

DavidCramer Jan 30, 2018

westonruter Jan 30, 2018

DavidCramer Jan 31, 2018

DavidCramer commented Jan 30, 2018

DavidCramer Jan 31, 2018


		$args = array_slice( func_get_args(), 4 );

		$output = '<amp-live-list layout="container" data-poll-interval="15000" data-max-items-per-page="20" id="amp-live-comments-list">';

Add amp-live-list comments #909

Add amp-live-list comments #909

Conversation

DavidCramer commented Jan 26, 2018 • edited by westonruter Loading

westonruter commented Jan 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DavidCramer Jan 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DavidCramer commented Jan 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DavidCramer commented Jan 30, 2018

Choose a reason for hiding this comment

DavidCramer commented Jan 26, 2018 •

edited by westonruter

Loading

DavidCramer Jan 30, 2018 •

edited

Loading