Skip to content

Conversation

@thedanielcho
Copy link

Description

This is a fix for #937 (comment) where I switched out the esc_html function call for strip_tags for the displayName to fix an apostrophe display issue on the post-edit page.

Should include any special considerations, decisions, and links to relevant GitHub issues.

Please don't include internal or private links

Deploy Notes

Are there any new dependencies added that should be taken into account when deploying to WordPress.org?

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Check out PR.
  2. Do stuff

@GaryJones
Copy link
Contributor

Thanks, Daniel.

I'm not convinced that the escaping should be done before the REST response is sent back since there's no idea of what context that escaping should be for - will it be for HTML, an attribute, XML, or something else? Needs an investigation.

@GaryJones GaryJones added type: bug Something isn't working status: needs investigation Needs further investigation labels Jul 22, 2023
@GaryJones GaryJones added this to the Future milestone Jul 27, 2023
@GaryJones GaryJones changed the base branch from main to develop August 25, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs investigation Needs further investigation type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants