Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise tutorial #569

Closed
5 tasks done
musslick opened this issue Sep 12, 2023 · 4 comments · Fixed by #584 or #595
Closed
5 tasks done

Revise tutorial #569

musslick opened this issue Sep 12, 2023 · 4 comments · Fixed by #584 or #595
Assignees
Labels
documentation Improvements or additions to documentation. priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.

Comments

@musslick
Copy link
Collaborator

musslick commented Sep 12, 2023

Requirements:

Tasks:

@musslick musslick added the documentation Improvements or additions to documentation. label Sep 12, 2023
@musslick
Copy link
Collaborator Author

musslick commented Sep 12, 2023

@musslick musslick added the priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks. label Sep 12, 2023
@chadcwilliams
Copy link
Collaborator

I am not certain how to implement the last three items for the tutorial (either I don't know what it means or else I don't know the explanation). I will bring this up in the next maintenance meeting.

@chadcwilliams
Copy link
Collaborator

Notes for Chad:

User dict functionality: Adding custom fields to the State (new state method)

Explain why the theorists doesn't have the decorator: b/c we use inherit scikit-learn interface rather than our custom interfaces w/ experimentalists and experiment runners (this is also for the wrapper) - i.e., why on_state vs estimator_on_state

Theorists: sometimes lists and sometimes models: If your delta object has one model return it, if it returns multiple models, make it a list.

@chadcwilliams
Copy link
Collaborator

All tasks completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. priority 1 - needed These are highly desirable to be fixed, ideally within 2 weeks.
Projects
None yet
2 participants