Map read-only collections by default #3368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbargaoanu
commented
Apr 7, 2020
lbargaoanu
changed the title
lbargaoanu
changed the title
|
Merge conflict on the api compat file |
|
@jbogard Ping :) |
not needed anymore map read-only collections by default cosmetic When_mapping_to_a_getter_only_ienumerable cosmetic cosmetic upgrade apicompat cosmetic cosmetic add 3.1 target for the integration tests update to Visual Studio 2019 retarget to 3.1 when mapping to an existing collection, we need ICollection, not IList
|
More merge conflicts :( |
|
Rebased. I'll check too :) |
|
I say let's ignore ApiCompat and check it at the end when we merge all the PR-s. Once we merge this one, I'll rebase the others. |
jbogard
approved these changes
Apr 29, 2020
|
This one and #3379 are good to go. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.