Replies: 7 comments 20 replies
-
The code doesn't work as you might think, the loginFuture is actually resolved in onDisconnected, so it's correct. |
Beta Was this translation helpful? Give feedback.
-
|
I'm referring to the last master: I understand you say that's correct, but when you call connect().join() the library doesn't return the control, api.connect().join()
System.out.println("hello") //<-- is not printedIn any case I din't find any reference to this in the documentation. |
Beta Was this translation helpful? Give feedback.
-
I'm pretty sure it gets executed after the connection is closed, then i could have changed some code that makes the future not get resolved. If you think that the future should return after the connection is established, how's it an anti pattern? That word doesn't even fit the context but okay I guess. I guess I could have two methods like connect and connectAndAwait, but then what's the point exactly? |
Beta Was this translation helpful? Give feedback.
-
|
Ok, so you complete the future on the disconnect.
Regarding the blocking after a while I will make a simple program in java to reproduce the issue. |
Beta Was this translation helpful? Give feedback.
-
|
I made this simple program to spot the issue that makes the library not working anymore after a while. package it.auties.whatsapp.commandline;
import it.auties.whatsapp.api.QrHandler;
import it.auties.whatsapp.api.WebHistoryLength;
import it.auties.whatsapp.api.Whatsapp;
import it.auties.whatsapp.model.contact.Contact;
import it.auties.whatsapp.model.contact.ContactJid;
import it.auties.whatsapp.model.message.standard.TextMessage;
import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.stream.LongStream;
public class RunningTest {
private static final Random randomGen = new Random();
public static void main(String args[]){
ExecutorService executor = Executors.newCachedThreadPool() ;
Whatsapp api = Whatsapp.webBuilder()
.newConnection()
.qrHandler(QrHandler.toTerminal())
.socketExecutor(executor)
.historyLength(WebHistoryLength.ZERO)
.build() ;
CompletableFuture<Whatsapp> future = api.connect().thenApply (connectedApi -> {
LongStream randomStream = randomGen.longs(0L, 240L);
randomStream.forEach(r -> {
long sleepMs = r * 1000 ;
System.out.println("Sleeping " + sleepMs + "milliseconds, then sending a message");
try {
Thread.sleep(sleepMs) ;
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
ContactJid contactJid = connectedApi.store().jid() ;
Contact contact = Contact.ofJid(contactJid) ;
TextMessage message = TextMessage.builder() // Create a new text message
.title("Test message")
.text("This is a test message")
.build() ;
connectedApi.sendMessage(contact, message) ;
});
return connectedApi ;
}) ;
future.join();
}
}Trying to run the program using the master branch I get the following exception related to protobuf that I don't understand: Thanks |
Beta Was this translation helpful? Give feedback.
-
you need to delegate build actions to maven as the protobuf plugin needs to run. If you are using intellij, there's an option in the settings |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the hint about protobuf. package it.auties.whatsapp.commandline;
import it.auties.whatsapp.api.QrHandler;
import it.auties.whatsapp.api.WebHistoryLength;
import it.auties.whatsapp.api.Whatsapp;
import it.auties.whatsapp.listener.OnWhatsappLoggedIn;
import it.auties.whatsapp.model.contact.Contact;
import it.auties.whatsapp.model.contact.ContactJid;
import it.auties.whatsapp.model.message.standard.TextMessage;
import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.stream.LongStream;
public class RunningTest {
private static final Random randomGen = new Random();
public static class __OnWhatsappLoggedIn implements OnWhatsappLoggedIn {
@Override
public void onLoggedIn(Whatsapp whatsapp) {
System.out.println("Logged In");
}
}
public static void main(String args[]){
ExecutorService executor = Executors.newCachedThreadPool() ;
Whatsapp api = Whatsapp.webBuilder()
.lastConnection()
.autodetectListeners(false)
.qrHandler(QrHandler.toTerminal())
.socketExecutor(executor)
.historyLength(WebHistoryLength.ZERO)
.build() ;
api.addLoggedInListener(new __OnWhatsappLoggedIn());
CompletableFuture<Whatsapp> future = api.connect().thenApply (connectedApi -> {
LongStream randomStream = randomGen.longs(0L, 30L);
randomStream.forEach(r -> {
long sleepMs = r * 1000 ;
System.out.println("Sleeping " + sleepMs + " milliseconds: timestamp(" + System.currentTimeMillis() + ")");
try {
Thread.sleep(sleepMs) ;
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
if(connectedApi.isConnected() && connectedApi.store().jid() != null) {
System.out.println("Trying to send a message");
ContactJid contactJid = connectedApi.store().jid() ;
Contact contact = Contact.ofJid(contactJid) ;
TextMessage message = TextMessage.builder() // Create a new text message
.title("Test message")
.text("This is a test message")
.build() ;
connectedApi.sendMessage(contact, message) ;
}
});
return connectedApi ;
}) ;
future.join();
System.out.println("End");
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Small correction: |
Beta Was this translation helpful? Give feedback.
-
|
No problem, it's clear that this is a development and not a stable branch. package it.auties.whatsapp.commandline;
import it.auties.whatsapp.api.QrHandler;
import it.auties.whatsapp.api.WebHistoryLength;
import it.auties.whatsapp.api.Whatsapp;
import it.auties.whatsapp.listener.OnWhatsappLoggedIn;
import it.auties.whatsapp.model.contact.Contact;
import it.auties.whatsapp.model.contact.ContactJid;
import it.auties.whatsapp.model.message.standard.TextMessage;
import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.stream.LongStream;
public class RunningTest2 {
private static final Random randomGen = new Random();
public static class __OnWhatsappLoggedIn implements OnWhatsappLoggedIn {
@Override
public void onLoggedIn(Whatsapp whatsapp) {
System.out.println("Logged In");
}
}
public static void main(String args[]){
ExecutorService executor = Executors.newCachedThreadPool() ;
Whatsapp api = Whatsapp.webBuilder()
.newConnection()
.autodetectListeners(false)
.qrHandler(QrHandler.toTerminal())
.socketExecutor(executor)
.historyLength(WebHistoryLength.ZERO)
.build() ;
api.addLoggedInListener(new __OnWhatsappLoggedIn());
CompletableFuture<Whatsapp> connectFuture = api.connect() ;
LongStream randomStream = randomGen.longs(0L, 30L);
randomStream.forEach(r -> {
long sleepMs = r * 1000 ;
System.out.println("Sleeping " + sleepMs + " milliseconds: timestamp(" + System.currentTimeMillis() + ")");
try {
Thread.sleep(sleepMs) ;
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
if(api.isConnected() && api.store().jid() != null) {
System.out.println("Trying to send a message");
ContactJid contactJid = api.store().jid() ;
Contact contact = Contact.ofJid(contactJid) ;
TextMessage message = TextMessage.builder() // Create a new text message
.title("Test message")
.text("This is a test message")
.build() ;
api.sendMessage(contact, message) ;
}
});
CompletableFuture<Void> future = new CompletableFuture<Void>() ;
future.join();
System.out.println("End");
}
} |
Beta Was this translation helpful? Give feedback.
-
|
I was finally able to make it working, it was necessary to add a check for disconnection because after the association a disconnection take place. Please, let me know if this program is using correctly the APIs. I'll keep you posted about the results of the test. This is the latest test program: package it.auties.whatsapp.commandline;
import it.auties.whatsapp.api.QrHandler;
import it.auties.whatsapp.api.WebHistoryLength;
import it.auties.whatsapp.api.Whatsapp;
import it.auties.whatsapp.listener.OnWhatsappLoggedIn;
import it.auties.whatsapp.model.contact.Contact;
import it.auties.whatsapp.model.contact.ContactJid;
import it.auties.whatsapp.model.message.standard.TextMessage;
import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.stream.LongStream;
public class RunningTest2 {
private static final Random randomGen = new Random();
public static class __OnWhatsappLoggedIn implements OnWhatsappLoggedIn {
@Override
public void onLoggedIn(Whatsapp whatsapp) {
System.out.println("Logged In: " + System.currentTimeMillis());
}
}
public static void main(String args[]){
//ExecutorService executor = Executors.newCachedThreadPool() ;
Whatsapp api = Whatsapp.webBuilder()
.newConnection()
.autodetectListeners(false)
.qrHandler(QrHandler.toTerminal())
//.socketExecutor(executor)
.historyLength(WebHistoryLength.ZERO)
.build() ;
api.addLoggedInListener(new __OnWhatsappLoggedIn());
CompletableFuture<Whatsapp> future = api.connect().thenApply (connectedApi -> {
LongStream randomStream = randomGen.longs(0L, 600L);
randomStream.forEach(r -> {
long sleepMs = r * 1000 ;
System.out.println("Sleeping " + sleepMs + " milliseconds: timestamp(" + System.currentTimeMillis() + ")");
try {
Thread.sleep(sleepMs) ;
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
if(! connectedApi.isConnected()) {
System.out.println("Reconnecting: " + System.currentTimeMillis() + ")");
connectedApi.reconnect().join() ;
System.out.println("Reconnected: " + System.currentTimeMillis() + ")");
} else if(connectedApi.store().jid() != null) {
long now = System.currentTimeMillis() ;
System.out.println("Trying to send a message: " + now);
ContactJid contactJid = connectedApi.store().jid() ;
Contact contact = Contact.ofJid(contactJid) ;
TextMessage message = TextMessage.builder() // Create a new text message
.title("Test message: " + now)
.text("This is a test message: " + now)
.build() ;
connectedApi.sendMessage(contact, message) ;
}
});
return connectedApi ;
}) ;
future.join();
System.out.println("End");
}
}Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
can you try with the stock master branch? you shouldn't need to reconnect manually |
Beta Was this translation helpful? Give feedback.
-
|
Sure, I'll let you know. |
Beta Was this translation helpful? Give feedback.
-
|
In the meantime I reproduced the error using the program of the previous comment, the library stop working with many of the following error statements: I will make the program working with the vanilla master branch. |
Beta Was this translation helpful? Give feedback.
-
|
So @Auties00 I was able to reproduce the error in about 1h and 10m, using the latest revision of the master branch and the last RunningTest2.java program in the previous comment. I suspect (but I'm not sure) that there are too many thread that do not return the control, i.e. several thread that instead of executing an action and terminate stay alive. Here you have the complete trace of the program: |
Beta Was this translation helpful? Give feedback.
-
I mean that's very strange for sure, I can guess that the pool has been terminated. Can you place a breakpoint in StreamHandler#dispose? |
Beta Was this translation helpful? Give feedback.
-
|
Of course! I ran the program with the breakpoint, let's check tomorrow for the results. |
Beta Was this translation helpful? Give feedback.
-
i have no clue why a cached thread pool would create problems, I'll look into it tomorrow. Yet i don't think it's related |
Beta Was this translation helpful? Give feedback.
-
|
Hey @Auties00 The program stopped on About the cached thread pool, just making hypotheses, but I mean that it could tell us something about how the thread are used, for instance, in some place they are never released. |
Beta Was this translation helpful? Give feedback.
-
|
Small update: tested twice today with the latest changes on master (febc646), the issues persists. |
Beta Was this translation helpful? Give feedback.
-
I can tell what's the issue, but i can't replicate it in anyway. I'll see if leaving it open for more than a day replicates it |
Beta Was this translation helpful? Give feedback.
-
That would be great. I can replicate the issue in 2 hours on average. Is it possible that the reproducibility depends on the amount of messages or events handled? Although the wa account I'm using is not busy at all. |
Beta Was this translation helpful? Give feedback.
-
i usually test with my personal account which is quite busy, so i doubt it |
Beta Was this translation helpful? Give feedback.
-
yeah, probably is unrelated unless is the small amount of traffic that could cause the handler dispose. |
Beta Was this translation helpful? Give feedback.
-
Hello I found an issue the first time the connect is made, a
new CompletableFuture<>();is returned that is never completed and that makes theconnect().join()never returning blocking the thread.The method, in SocketHandler.java is the following:
It make it working changing the function to:
I suspect that something similar happen in the CompletableFuture's in
ReplyHandler.javaandRequest.javasince after some minutes of running the connections stop working and the following exception is thrown (fromRequest.java->trace):Anybody have any idea of why after a while the library freezes?
Thanks for any help provided.
ps. I found an error on deserialization that I solved with the following change in
it/auties/whatsapp/binary/PatchType.java:Beta Was this translation helpful? Give feedback.
All reactions