Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Object.dirname is deprecated. #155

Closed
GBardis opened this issue Apr 14, 2017 · 2 comments
Closed

Object.dirname is deprecated. #155

GBardis opened this issue Apr 14, 2017 · 2 comments
Labels

Comments

@GBardis
Copy link

GBardis commented Apr 14, 2017

Argument to path.dirname must be a string

Object.dirname (/usr/share/atom/resources/app.asar/src/electron-shims.js:9:10)
<unknown> (/home/gdev/.atom/packages/linter-tslint/lib/main.js:232:50)
Object.<anonymous> (/home/gdev/.atom/packages/linter-tslint/lib/main.js:246:9)
undefined.next (null:null:null)
step (/home/gdev/.atom/packages/linter-tslint/lib/main.js:7:273)
@Arcanemagus
Copy link
Member

@Xapphire13 Although Linter is supposed to not trigger on never saved buffers, somehow we still get situations where textEditor.getPath() still returns undefined. This can probably be fixed by putting a check for that here.

@Xapphire13
Copy link
Contributor

Working on it =]. I'll add specs for this case too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants