Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Highlighting in the editor messing up with line numbers #13

Closed
sobit opened this issue May 14, 2015 · 7 comments
Closed

Highlighting in the editor messing up with line numbers #13

sobit opened this issue May 14, 2015 · 7 comments
Labels

Comments

@sobit
Copy link

sobit commented May 14, 2015

Using latest versions of Atom and packages.

Here a warning is produced:
screenshot 2015-05-14 16 58 57

But when you place a cursor on it, that's the message you get:
screenshot 2015-05-14 16 59 08

Which apparently is related to the next line in the editor (19).

Running tslint manually though shows the information properly:

src/index.ts[19, 11]: expected variable-declaration: 'stripe' to have a typedef

So I guess it's a problem with either linter or linter-tslint. Would appreciate any help.

@trkoch
Copy link

trkoch commented May 21, 2015

I can confirm this behavior (Atom 0.200.0, Mac OS X, linter-tslint 0.2.1, built-in tslint). Any hints?

@trkoch
Copy link

trkoch commented May 21, 2015

I suspect substracting one line (or column) in processMessage (found in file linter-tslint.coffee) should be removed.

@pleerock
Copy link

+1

@tomitrescak
Copy link

Yes, still the same at latest version.

@czottmann
Copy link

+1

@czottmann
Copy link

Update: after clearing the "Tslint Executable Path" in the linter-tslint settings (making it use its packaged tslint), the line and columns are marked correctly.

Atom 0.211, linter-tslint 0.2.2, OS X 10.10.3.

@adidahiya
Copy link
Contributor

TS language services fixed the way they report line and col numbers (I think in TS v1.4?) and that change propagated to tslint. So you no longer have to subtract 1 from the reported line and column position. I opened a PR with the fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants